Bug 185864

Summary:

[JSC] Clean up stringGetByValStubGenerator

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews205 for win-future	none
Archive of layout-test-results from ews202 for win-future	none
Patch	none
Patch	saam: review+

Yusuke Suzuki

Reported 2018-05-22 05:20:03 PDT

[JSC] Clean up stringGetByValStubGenerator

Attachments
Patch (11.57 KB, patch) 2018-05-22 05:21 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews205 for win-future (13.28 MB, application/zip) 2018-05-22 09:44 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews202 for win-future (13.45 MB, application/zip) 2018-05-22 11:30 PDT, EWS Watchlist	no flags	Details
Patch (12.23 KB, patch) 2018-05-22 16:00 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (12.28 KB, patch) 2018-05-22 16:05 PDT, Yusuke Suzuki	saam: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2018-05-22 05:21:54 PDT

Created attachment 340975 [details] Patch

EWS Watchlist

Comment 2 2018-05-22 09:44:24 PDT

Comment on attachment 340975 [details] Patch Attachment 340975 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7765628 New failing tests: fast/canvas/set-colors.html workers/bomb.html printing/width-overflow.html js/dfg-string-out-of-bounds-check-structure.html js/get-by-pname.html

EWS Watchlist

Comment 3 2018-05-22 09:44:35 PDT

Created attachment 340988 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

EWS Watchlist

Comment 4 2018-05-22 11:30:42 PDT

Comment on attachment 340975 [details] Patch Attachment 340975 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7766543 New failing tests: js/get-by-pname.html workers/bomb.html js/dfg-string-out-of-bounds-check-structure.html printing/width-overflow.html fast/canvas/set-colors.html

EWS Watchlist

Comment 5 2018-05-22 11:30:54 PDT

Created attachment 340997 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Yusuke Suzuki

Comment 6 2018-05-22 16:00:10 PDT

Created attachment 341038 [details] Patch

Yusuke Suzuki

Comment 7 2018-05-22 16:05:54 PDT

Created attachment 341041 [details] Patch

Yusuke Suzuki

Comment 8 2018-05-22 22:05:18 PDT

Committed r232106: <https://trac.webkit.org/changeset/232106>

Radar WebKit Bug Importer

Comment 9 2018-05-22 22:08:09 PDT

<rdar://problem/40475606>

Note You need to log in before you can comment on or make changes to this bug.