Bug 185809

Summary:

Modernize RenderStyleConstants.h - Part 1

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, ews-watchlist, rniwa, simon.fraser, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews112 for mac-sierra	none
Archive of layout-test-results from ews101 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews117 for mac-sierra	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	none

Sam Weinig

Reported 2018-05-20 17:04:12 PDT

Modernize RenderStyleConstants.h - Part 1

Attachments
Patch (671.70 KB, patch) 2018-05-20 17:27 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (673.74 KB, patch) 2018-05-20 17:53 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews112 for mac-sierra (384.90 KB, application/zip) 2018-05-20 18:55 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews101 for mac-sierra (2.44 MB, application/zip) 2018-05-20 19:09 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.98 MB, application/zip) 2018-05-20 19:15 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.38 MB, application/zip) 2018-05-20 19:48 PDT, EWS Watchlist	no flags	Details
Patch (674.12 KB, patch) 2018-05-20 20:28 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews117 for mac-sierra (377.74 KB, application/zip) 2018-05-20 21:33 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews102 for mac-sierra (2.47 MB, application/zip) 2018-05-20 21:43 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.90 MB, application/zip) 2018-05-20 21:48 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (20.03 MB, application/zip) 2018-05-20 22:22 PDT, EWS Watchlist	no flags	Details
Patch (682.62 KB, patch) 2018-05-20 22:27 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2018-05-20 17:27:37 PDT

Created attachment 340810 [details] Patch

EWS Watchlist

Comment 2 2018-05-20 17:30:11 PDT

Attachment 340810 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:509: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:751: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/page/FrameView.cpp:666: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/page/FrameView.cpp:684: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderTreeAsText.cpp:86: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderLayerCompositor.cpp:2374: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:1082: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:655: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:656: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:657: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:658: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:659: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:660: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:665: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:666: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:667: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:668: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:669: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:670: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:671: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:672: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:673: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:677: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:678: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:679: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:680: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:698: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:776: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:780: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:781: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:785: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:786: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:787: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:788: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:792: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:793: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:797: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:798: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:799: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:855: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:856: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:857: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:858: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:859: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:860: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:861: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:862: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:863: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:864: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:865: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:866: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:867: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:868: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:869: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:870: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:871: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:872: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:873: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:874: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:875: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:876: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:877: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:878: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:879: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:889: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:890: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:891: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:892: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:893: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:894: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:895: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:896: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:897: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:898: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:935: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3417: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 76 in 153 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 3 2018-05-20 17:35:07 PDT

There are few new names I am not thrilled with but don't know if my alternate ideas are any better: - PositionType This can't be just Position, since there is already a WebCore::Position class. Was thinking maybe Positioned or PositionMode might be better? - Float This just feels to close to the primitive float. Maybe Floating? - Clear This just seems too abstract. Maybe something like ClearFloating? - FillAttachment Here, my concern is with the value names for which I chose: ScrollBackground, LocalBackground and FixedBackground. Maybe leave off the background suffix?

Sam Weinig

Comment 4 2018-05-20 17:53:55 PDT

Created attachment 340811 [details] Patch

EWS Watchlist

Comment 5 2018-05-20 17:56:43 PDT

Attachment 340811 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:509: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:751: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/page/FrameView.cpp:666: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/page/FrameView.cpp:684: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderTreeAsText.cpp:86: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderLayerCompositor.cpp:2374: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:1082: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:655: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:656: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:657: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:658: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:659: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:660: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:665: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:666: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:667: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:668: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:669: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:670: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:671: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:672: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:673: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:677: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:678: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:679: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:680: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:698: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:776: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:780: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:781: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:785: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:786: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:787: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:788: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:792: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:793: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:797: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:798: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:799: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:855: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:856: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:857: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:858: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:859: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:860: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:861: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:862: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:863: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:864: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:865: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:866: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:867: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:868: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:869: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:870: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:871: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:872: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:873: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:874: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:875: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:876: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:877: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:878: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:879: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:889: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:890: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:891: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:892: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:893: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:894: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:895: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:896: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:897: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:898: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:935: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3417: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 76 in 155 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 6 2018-05-20 18:29:25 PDT

Comment on attachment 340811 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340811&action=review r=me, nice! Code becomes significantly readable. > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3635 > - if (style.aspectRatioType() == AspectRatioAuto) > + if (style.aspectRatioType() == AspectRatioType::Auto) > return cssValuePool.createIdentifierValue(CSSValueAuto); > - if (style.aspectRatioType() == AspectRatioFromDimensions) > + if (style.aspectRatioType() == AspectRatioType::FromDimensions) > return cssValuePool.createIdentifierValue(CSSValueFromDimensions); > - if (style.aspectRatioType() == AspectRatioFromIntrinsic) > + if (style.aspectRatioType() == AspectRatioType::FromIntrinsic) > return cssValuePool.createIdentifierValue(CSSValueFromIntrinsic); How about using `switch`? > Source/WebCore/css/CSSPrimitiveValueMappings.h:319 > + return (BorderStyle)(m_value.valueID - CSSValueNone); Use `static_cast<>` > Source/WebCore/rendering/HitTestResult.cpp:280 > + if (block.style().textOverflow() == TextOverflow::Ellipsis) { I like these changes. > Source/WebCore/rendering/RenderBlockFlow.cpp:2555 > default: This `default:` can be `case Clear::None:`. > Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:521 > + default: // BoxAlignment::Start Does this include `BoxAlignment::Strech`? If so, adding a comment would be nice. > Source/WebCore/rendering/RenderElement.cpp:266 > +StyleDifference RenderElement::adjustStyleDifference(StyleDifference diff, OptionSet<StyleDifferenceContextSensitiveProperty> contextSensitiveProperties) const Nice.

EWS Watchlist

Comment 7 2018-05-20 18:55:13 PDT

Comment on attachment 340811 [details] Patch Attachment 340811 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7747839 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 8 2018-05-20 18:55:15 PDT

Created attachment 340813 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 9 2018-05-20 19:09:48 PDT

Comment on attachment 340811 [details] Patch Attachment 340811 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7747931 New failing tests: css3/flexbox/csswg/flexbox_rtl-direction.html fast/text/word-space.html fast/block/float/029.html fast/block/float/clear-to-fit.html fast/block/float/float-overflow-hidden-containing-block-width.html imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-layout-auto-tracks.html fast/block/float/nowrap-clear-min-width.html

EWS Watchlist

Comment 10 2018-05-20 19:09:50 PDT

Created attachment 340814 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 11 2018-05-20 19:15:14 PDT

Comment on attachment 340811 [details] Patch Attachment 340811 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7747939 New failing tests: css3/flexbox/csswg/flexbox_rtl-direction.html fast/text/word-space.html fast/block/float/029.html fast/block/float/clear-to-fit.html fast/block/float/float-overflow-hidden-containing-block-width.html imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-layout-auto-tracks.html fast/block/float/nowrap-clear-min-width.html

EWS Watchlist

Comment 12 2018-05-20 19:15:15 PDT

Created attachment 340815 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 13 2018-05-20 19:48:32 PDT

Comment on attachment 340811 [details] Patch Attachment 340811 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7747985 New failing tests: css3/flexbox/csswg/flexbox_rtl-direction.html fast/block/float/029.html fast/block/float/clear-to-fit.html fast/block/float/float-overflow-hidden-containing-block-width.html imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-layout-auto-tracks.html fast/block/float/nowrap-clear-min-width.html

EWS Watchlist

Comment 14 2018-05-20 19:48:34 PDT

Created attachment 340816 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Sam Weinig

Comment 15 2018-05-20 20:28:37 PDT

Created attachment 340817 [details] Patch

Sam Weinig

Comment 16 2018-05-20 20:29:41 PDT

(In reply to Yusuke Suzuki from comment #6) > Comment on attachment 340811 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=340811&action=review > > r=me, nice! Code becomes significantly readable. Thanks for reviewing! > > > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3635 > > - if (style.aspectRatioType() == AspectRatioAuto) > > + if (style.aspectRatioType() == AspectRatioType::Auto) > > return cssValuePool.createIdentifierValue(CSSValueAuto); > > - if (style.aspectRatioType() == AspectRatioFromDimensions) > > + if (style.aspectRatioType() == AspectRatioType::FromDimensions) > > return cssValuePool.createIdentifierValue(CSSValueFromDimensions); > > - if (style.aspectRatioType() == AspectRatioFromIntrinsic) > > + if (style.aspectRatioType() == AspectRatioType::FromIntrinsic) > > return cssValuePool.createIdentifierValue(CSSValueFromIntrinsic); > > How about using `switch`? Fixed. > > > Source/WebCore/css/CSSPrimitiveValueMappings.h:319 > > + return (BorderStyle)(m_value.valueID - CSSValueNone); > > Use `static_cast<>` Fixed. > > > Source/WebCore/rendering/HitTestResult.cpp:280 > > + if (block.style().textOverflow() == TextOverflow::Ellipsis) { > > I like these changes. > > > Source/WebCore/rendering/RenderBlockFlow.cpp:2555 > > default: > > This `default:` can be `case Clear::None:`. Fixed. > > > Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:521 > > + default: // BoxAlignment::Start > > Does this include `BoxAlignment::Strech`? If so, adding a comment would be > nice. I'm not 100% sure, so I left it alone for now.

EWS Watchlist

Comment 17 2018-05-20 20:30:57 PDT

Attachment 340817 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:509: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:751: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/page/FrameView.cpp:666: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/page/FrameView.cpp:684: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderTreeAsText.cpp:86: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderLayerCompositor.cpp:2374: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:1082: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:655: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:656: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:657: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:658: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:659: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:660: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:665: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:666: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:667: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:668: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:669: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:670: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:671: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:672: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:673: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:677: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:678: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:679: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:680: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:698: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:776: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:780: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:781: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:785: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:786: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:787: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:788: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:792: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:793: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:797: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:798: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:799: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:855: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:856: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:857: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:858: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:859: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:860: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:861: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:862: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:863: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:864: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:865: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:866: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:867: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:868: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:869: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:870: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:871: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:872: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:873: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:874: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:875: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:876: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:877: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:878: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:879: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:889: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:890: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:891: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:892: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:893: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:894: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:895: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:896: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:897: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:898: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:935: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3417: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 76 in 155 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 18 2018-05-20 21:33:21 PDT

Comment on attachment 340817 [details] Patch Attachment 340817 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7748701 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 19 2018-05-20 21:33:22 PDT

Created attachment 340820 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 20 2018-05-20 21:43:18 PDT

Comment on attachment 340817 [details] Patch Attachment 340817 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7748757 New failing tests: fast/text/word-space.html imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-layout-auto-tracks.html fast/block/float/029.html css3/flexbox/csswg/flexbox_rtl-direction.html fast/block/float/clear-to-fit.html

EWS Watchlist

Comment 21 2018-05-20 21:43:20 PDT

Created attachment 340822 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 22 2018-05-20 21:48:53 PDT

Comment on attachment 340817 [details] Patch Attachment 340817 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7748770 New failing tests: fast/text/word-space.html imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-layout-auto-tracks.html fast/block/float/029.html css3/flexbox/csswg/flexbox_rtl-direction.html fast/block/float/clear-to-fit.html

EWS Watchlist

Comment 23 2018-05-20 21:48:54 PDT

Created attachment 340823 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 24 2018-05-20 22:21:58 PDT

Comment on attachment 340817 [details] Patch Attachment 340817 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7748819 New failing tests: imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-layout-auto-tracks.html css3/flexbox/csswg/flexbox_rtl-direction.html fast/block/float/029.html fast/block/float/clear-to-fit.html

EWS Watchlist

Comment 25 2018-05-20 22:22:00 PDT

Created attachment 340826 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Sam Weinig

Comment 26 2018-05-20 22:27:55 PDT

Created attachment 340827 [details] Patch

EWS Watchlist

Comment 27 2018-05-20 22:30:20 PDT

Attachment 340827 [details] did not pass style-queue: ERROR: Source/WebCore/page/FrameView.cpp:680: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] ERROR: Source/WebCore/page/FrameView.cpp:698: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:655: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:656: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:657: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:658: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:659: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:660: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:665: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:666: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:667: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:668: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:669: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:670: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:671: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:672: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:673: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:677: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:678: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:679: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:680: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:698: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:776: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:780: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:781: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:785: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:786: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:787: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:788: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:792: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:793: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:797: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:798: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:799: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:855: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:856: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:857: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:858: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:859: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:860: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:861: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:862: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:863: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:864: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:865: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:866: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:867: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:868: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:869: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:870: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:871: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:872: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:873: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:874: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:875: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:876: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:877: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:878: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:879: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:889: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:890: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:891: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:892: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:893: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:894: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:895: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:896: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:897: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:898: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:935: Missing spaces around | [whitespace/operators] [3] Total errors found: 70 in 156 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 28 2018-05-21 09:55:54 PDT

Comment on attachment 340827 [details] Patch Clearing flags on attachment: 340827 Committed r232018: <https://trac.webkit.org/changeset/232018>

WebKit Commit Bot

Comment 29 2018-05-21 09:55:56 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 30 2018-05-21 09:58:37 PDT

<rdar://problem/40419255>

Simon Fraser (smfr)

Comment 31 2018-05-21 11:02:16 PDT

EVeryNice

Note You need to log in before you can comment on or make changes to this bug.