Bug 185788

Summary:

Test infrastructure websites should use jQuery and jQuery UI hosted on webkit.org

Product:

WebKit

Reporter:

Roy Reapor <rreapor>

Component:

Tools / Tests

Assignee:

Roy Reapor <rreapor>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ews-watchlist, lforschler, rreapor, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Roy Reapor 2018-05-18 14:47:31 PDT

Test infrastructure websites should use jQuery and jQuery UI hosted in webkit.org

Comment 1 Radar WebKit Bug Importer 2018-05-18 14:48:45 PDT

<rdar://problem/40378423>

Comment 2 Roy Reapor 2018-05-18 15:10:16 PDT

Created attachment 340742 [details]
Patch

Comment 3 EWS Watchlist 2018-05-18 15:12:49 PDT

Attachment 340742 [details] did not pass style-queue:


ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:347:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:362:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:363:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:364:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:365:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:366:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:369:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:372:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:373:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:374:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:375:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:376:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:377:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:380:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:381:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:382:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:383:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:384:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:388:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:389:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 20 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Roy Reapor 2018-05-22 12:07:20 PDT

Created attachment 341003 [details]
Patch

Comment 5 EWS Watchlist 2018-05-22 12:08:31 PDT

Attachment 341003 [details] did not pass style-queue:


ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:347:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:362:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:363:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:364:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:365:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:366:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:369:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:372:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:373:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:374:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:375:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:376:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:377:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:380:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:381:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:382:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:383:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:384:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:388:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:389:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 20 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 6 Roy Reapor 2018-05-22 13:05:51 PDT

(In reply to Build Bot from comment #5)
> Attachment 341003 [details] did not pass style-queue:
> 
> 
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:347: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:362: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:363: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:364: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:365: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:366: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:369: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:372: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:373: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:374: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:375: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:376: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:377: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:380: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:381: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:382: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:383: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:384: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:388: 
> Line contains tab character.  [whitespace/tab] [5]
> ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:389: 
> Line contains tab character.  [whitespace/tab] [5]
> Total errors found: 20 in 12 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

Patch includes "allow-tabs" property for jquery-ui-1.8.15.css . It is reviewable.

Comment 7 Aakash Jain 2018-05-22 13:39:26 PDT

Comment on attachment 341003 [details]
Patch

looks fine to me.

Comment 8 Ryan Haddad 2018-05-22 16:42:26 PDT

Comment on attachment 341003 [details]
Patch

Clearing flags on attachment: 341003

Committed r232085: <https://trac.webkit.org/changeset/232085>

Comment 9 Ryan Haddad 2018-05-22 16:42:28 PDT

All reviewed patches have been landed.  Closing bug.