Bug 185788

Summary: Test infrastructure websites should use jQuery and jQuery UI hosted on webkit.org
Product: WebKit Reporter: Roy Reapor <rreapor>
Component: Tools / TestsAssignee: Roy Reapor <rreapor>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ews-watchlist, lforschler, rreapor, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Roy Reapor
Reported 2018-05-18 14:47:31 PDT
Test infrastructure websites should use jQuery and jQuery UI hosted in webkit.org
Attachments
Patch (330.88 KB, patch)
2018-05-18 15:10 PDT, Roy Reapor 		no flags
DetailsFormatted DiffDiff
Patch (331.07 KB, patch)
2018-05-22 12:07 PDT, Roy Reapor 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-05-18 14:48:45 PDT
<rdar://problem/40378423>
Roy Reapor
Comment 2 2018-05-18 15:10:16 PDT
Created attachment 340742 [details] Patch
EWS Watchlist
Comment 3 2018-05-18 15:12:49 PDT
Attachment 340742 [details] did not pass style-queue: ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:347: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:362: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:363: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:364: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:365: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:366: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:369: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:372: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:373: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:374: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:375: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:376: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:377: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:380: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:381: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:382: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:383: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:384: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:388: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:389: Line contains tab character. [whitespace/tab] [5] Total errors found: 20 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Roy Reapor
Comment 4 2018-05-22 12:07:20 PDT
Created attachment 341003 [details] Patch
EWS Watchlist
Comment 5 2018-05-22 12:08:31 PDT
Attachment 341003 [details] did not pass style-queue: ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:347: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:362: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:363: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:364: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:365: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:366: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:369: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:372: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:373: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:374: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:375: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:376: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:377: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:380: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:381: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:382: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:383: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:384: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:388: Line contains tab character. [whitespace/tab] [5] ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:389: Line contains tab character. [whitespace/tab] [5] Total errors found: 20 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Roy Reapor
Comment 6 2018-05-22 13:05:51 PDT
(In reply to Build Bot from comment #5) > Attachment 341003 [details] did not pass style-queue: > > > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:347: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:362: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:363: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:364: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:365: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:366: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:369: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:372: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:373: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:374: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:375: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:376: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:377: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:380: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:381: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:382: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:383: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:384: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:388: > Line contains tab character. [whitespace/tab] [5] > ERROR: Websites/webkit.org/ajax/libs/jqueryui/jquery-ui-1.8.15.css:389: > Line contains tab character. [whitespace/tab] [5] > Total errors found: 20 in 12 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Patch includes "allow-tabs" property for jquery-ui-1.8.15.css . It is reviewable.
Aakash Jain
Comment 7 2018-05-22 13:39:26 PDT
Comment on attachment 341003 [details] Patch looks fine to me.
Ryan Haddad
Comment 8 2018-05-22 16:42:26 PDT
Comment on attachment 341003 [details] Patch Clearing flags on attachment: 341003 Committed r232085: <https://trac.webkit.org/changeset/232085>
Ryan Haddad
Comment 9 2018-05-22 16:42:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.