Bug 185770

Summary: Complete fix for enabling modern EME by default
Product: WebKit Reporter: Jon Lee <jonlee>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, jer.noble, jonlee, keith_miller, mark.lam, msaboff, realdawei, rniwa, ryanhaddad, sbarati, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 185793    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews103 for mac-sierra
none
Archive of layout-test-results from ews106 for mac-sierra-wk2
none
Archive of layout-test-results from ews113 for mac-sierra
none
Patch for landing
none
Patch for landing
none
Archive of layout-test-results from ews106 for mac-sierra-wk2
none
Patch for landing none

Description Jon Lee 2018-05-18 09:55:04 PDT
Complete fix for enabling modern EME by default
Comment 1 Radar WebKit Bug Importer 2018-05-18 09:55:50 PDT
<rdar://problem/40368220>
Comment 2 Jer Noble 2018-05-18 09:58:12 PDT
Created attachment 340705 [details]
Patch
Comment 3 EWS Watchlist 2018-05-18 11:20:33 PDT Comment hidden (obsolete)
Comment 4 EWS Watchlist 2018-05-18 11:20:34 PDT Comment hidden (obsolete)
Comment 5 EWS Watchlist 2018-05-18 11:36:06 PDT Comment hidden (obsolete)
Comment 6 EWS Watchlist 2018-05-18 11:36:08 PDT Comment hidden (obsolete)
Comment 7 EWS Watchlist 2018-05-18 11:45:49 PDT Comment hidden (obsolete)
Comment 8 EWS Watchlist 2018-05-18 11:45:50 PDT Comment hidden (obsolete)
Comment 9 Jer Noble 2018-05-18 12:08:19 PDT
Created attachment 340725 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2018-05-18 14:29:33 PDT
Comment on attachment 340725 [details]
Patch for landing

Clearing flags on attachment: 340725

Committed r231982: <https://trac.webkit.org/changeset/231982>
Comment 11 WebKit Commit Bot 2018-05-18 14:29:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Dawei Fenton (:realdawei) 2018-05-18 16:22:44 PDT
It looks like this change is failing layout tests on High Sierra WK1

https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/r231983%20(5465)/results.html
Comment 13 Ryan Haddad 2018-05-18 16:46:21 PDT
(In reply to David Fenton from comment #12)
> It looks like this change is failing layout tests on High Sierra WK1
> 
> https://build.webkit.org/results/
> Apple%20High%20Sierra%20Release%20WK1%20(Tests)/r231983%20(5465)/results.html

Same on High Sierra WK2:
https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r231983%20(4592)/results.html

  fast/dom/navigator-detached-no-crash.html [ Failure ]
  platform/mac/media/encrypted-media/fps-createMediaKeys.html [ Failure ]
  platform/mac/media/encrypted-media/fps-createSession.html [ Failure ]
  platform/mac/media/encrypted-media/fps-encrypted-event.html [ Failure ]
  platform/mac/media/encrypted-media/fps-generateRequest.html [ Failure ]
  platform/mac/media/encrypted-media/fps-requestMediaKeySystemAccess.html [ Timeout ]
Comment 14 Ryan Haddad 2018-05-18 17:05:35 PDT
We're going to roll this out since it is affecting EWS.
Comment 15 WebKit Commit Bot 2018-05-18 17:06:34 PDT
Re-opened since this is blocked by bug 185793
Comment 16 Jer Noble 2018-05-21 10:31:44 PDT
Created attachment 340860 [details]
Patch for landing
Comment 17 EWS Watchlist 2018-05-21 12:02:19 PDT
Comment on attachment 340860 [details]
Patch for landing

Attachment 340860 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7754593

New failing tests:
fast/dom/navigator-detached-no-crash.html
Comment 18 EWS Watchlist 2018-05-21 12:02:21 PDT
Created attachment 340869 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 19 Jer Noble 2018-05-21 12:30:58 PDT
Created attachment 340872 [details]
Patch for landing
Comment 20 WebKit Commit Bot 2018-05-21 13:50:53 PDT
Comment on attachment 340872 [details]
Patch for landing

Clearing flags on attachment: 340872

Committed r232024: <https://trac.webkit.org/changeset/232024>
Comment 21 WebKit Commit Bot 2018-05-21 13:50:54 PDT
All reviewed patches have been landed.  Closing bug.