Bug 185763

Summary: [GTK] MiniBrowser crashes when loading twice quickly
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, ews-watchlist, lforschler, mcatanzaro, rniwa, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mcatanzaro: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews104 for mac-sierra-wk2 none

Description Carlos Garcia Campos 2018-05-18 03:53:05 PDT
This is very difficult to reproduce manually, but it happens when running WebDriver tests where loads are very fast and multiple loads are done quickly. The problem is that we use an idle to resent the progress bar, but we don't reset it when a new load starts. We always reset the last idle on destroy, but if there's another one leaked, it will crash when scheduled if the window has already been destroyed.

Thread 1 "MiniBrowser" received signal SIGSEGV, Segmentation fault.
g_type_check_instance_cast (type_instance=0xaaaaaaaaaaaaaaaa, 
    iface_type=94876889051072) at gtype.c:4052
4052	      if (type_instance->g_class)
(gdb) bt
#0  g_type_check_instance_cast (type_instance=0xaaaaaaaaaaaaaaaa, 
    iface_type=94876889051072) at gtype.c:4052
#1  0x0000564a3e32c345 in resetEntryProgress ()
#2  0x00007f2c58c79063 in g_timeout_dispatch (
    source=source@entry=0x564a3f26ca00, callback=<optimized out>, 
    user_data=<optimized out>) at gmain.c:4650
#3  0x00007f2c58c78615 in g_main_dispatch (context=0x564a3f006290)
    at gmain.c:3177
#4  g_main_context_dispatch (context=context@entry=0x564a3f006290)
    at gmain.c:3830
#5  0x00007f2c58c789b8 in g_main_context_iterate (context=0x564a3f006290, 
    block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>)
    at gmain.c:3903
#6  0x00007f2c58c78cc2 in g_main_loop_run (loop=0x564a3f52fbf0) at gmain.c:4099
#7  0x00007f2c5a834e25 in gtk_main () at gtkmain.c:1323
#8  0x0000564a3e32567c in main ()
Comment 1 Carlos Garcia Campos 2018-05-18 03:55:29 PDT
Created attachment 340687 [details]
Patch
Comment 2 EWS Watchlist 2018-05-18 06:03:06 PDT
Comment on attachment 340687 [details]
Patch

Attachment 340687 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7721376

New failing tests:
transitions/created-while-suspended.html
Comment 3 EWS Watchlist 2018-05-18 06:03:08 PDT
Created attachment 340689 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 4 Carlos Garcia Campos 2018-05-20 23:25:05 PDT
Committed r232009: <https://trac.webkit.org/changeset/232009>
Comment 5 Radar WebKit Bug Importer 2018-05-20 23:26:25 PDT
<rdar://problem/40407917>