Bug 185758

Summary: Web Inspector: Canvas: put `hasVisualEffect` behind an experimental setting
Product: WebKit Reporter: Devin Rousso <drousso>
Component: Web InspectorAssignee: Devin Rousso <drousso>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 173807, 185635    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews200 for win-future none

Description Devin Rousso 2018-05-17 21:27:12 PDT
There is no "easy" way to quickly determine if a particular visual action caused some pixels to change on the canvas, so we have to resort to checking every single pixel.  On larger canvases, this can take a long time, and the problem is compounded if there are a large number of visual actions in the recording.  We should put this behind a setting so that if the user doesn't particularly need/care about `hasVisualEffect` they don't need to suffer the performance hit.
Comment 1 Devin Rousso 2018-05-17 21:28:48 PDT
Created attachment 340677 [details]
Patch
Comment 2 EWS Watchlist 2018-05-18 11:53:32 PDT
Comment on attachment 340677 [details]
Patch

Attachment 340677 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7723773

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
Comment 3 EWS Watchlist 2018-05-18 11:53:42 PDT
Created attachment 340721 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 Matt Baker 2018-05-18 13:38:30 PDT
Comment on attachment 340677 [details]
Patch

r=me
Comment 5 Matt Baker 2018-05-18 13:55:42 PDT
<rdar://problem/40240813>
Comment 6 WebKit Commit Bot 2018-05-18 14:05:14 PDT
Comment on attachment 340677 [details]
Patch

Clearing flags on attachment: 340677

Committed r231981: <https://trac.webkit.org/changeset/231981>
Comment 7 WebKit Commit Bot 2018-05-18 14:05:15 PDT
All reviewed patches have been landed.  Closing bug.