| Summary: | CRASH in ImageDecoderAVFObjC::sampleAtIndex() | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ap, commit-queue, eric.carlson, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jer Noble
2018-05-17 10:18:03 PDT
Created attachment 340603 [details]
Patch
Comment on attachment 340603 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340603&action=review > LayoutTests/fast/images/animated-image-mp4-crash.html:8 > + var imageData; Nit: "var" here "let" below, should be consistent. > LayoutTests/fast/images/animated-image-mp4-crash.html:12 > + let image = document.querySelector('img'); Nit: could use const here instead of let. Created attachment 340620 [details]
Patch for landing
Comment on attachment 340620 [details] Patch for landing Rejecting attachment 340620 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 340620, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/7713202 Created attachment 340630 [details]
Patch for landing
Comment on attachment 340630 [details] Patch for landing Clearing flags on attachment: 340630 Committed r231920: <https://trac.webkit.org/changeset/231920> All reviewed patches have been landed. Closing bug. |