Bug 185706

Summary: [iOS] Update AirPlay route monitoring
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: ASSIGNED ---    
Severity: Normal CC: commit-queue, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
jer.noble: review+
Patch for landing
none
Build fix. none

Description Eric Carlson 2018-05-16 17:26:46 PDT
Update the API used to monitor AirPlay routes.
Comment 1 Eric Carlson 2018-05-16 17:28:00 PDT
<rdar://problem/40230677>
Comment 2 Eric Carlson 2018-05-17 09:23:46 PDT
Created attachment 340591 [details]
Patch
Comment 3 Jer Noble 2018-05-17 10:27:42 PDT
Comment on attachment 340591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340591&action=review

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:463
> +        if (!protectedSelf->_callback)
>              return;
>  
> -        _callback->applicationWillEnterForeground(isSuspendedUnderLock);
> +        protectedSelf->_callback->applicationWillEnterForeground(isSuspendedUnderLock);

Nit: this and the next 4 instances of this pattern could have a reversed if case:

if (auto* callback = protectedSelf->callback)
    callback->applicationWillEnterForeground(isSuspendedUnderLock);
Comment 4 Eric Carlson 2018-05-17 11:26:56 PDT
Created attachment 340610 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-05-17 11:44:38 PDT
Comment on attachment 340610 [details]
Patch for landing

Clearing flags on attachment: 340610

Committed r231913: <https://trac.webkit.org/changeset/231913>
Comment 6 Eric Carlson 2018-05-17 14:10:05 PDT
Created attachment 340638 [details]
Build fix.
Comment 7 WebKit Commit Bot 2018-05-17 14:48:54 PDT
Comment on attachment 340638 [details]
Build fix.

Clearing flags on attachment: 340638

Committed r231921: <https://trac.webkit.org/changeset/231921>