Bug 185706

Summary: [iOS] Update AirPlay route monitoring
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: ASSIGNED    
Severity: Normal CC: commit-queue, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
jer.noble: review+
Patch for landing
none
Build fix. none

Eric Carlson
Reported 2018-05-16 17:26:46 PDT
Update the API used to monitor AirPlay routes.
Attachments
Patch (15.60 KB, patch)
2018-05-17 09:23 PDT, Eric Carlson 		jer.noble: review+
DetailsFormatted DiffDiff
Patch for landing (15.83 KB, patch)
2018-05-17 11:26 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Build fix. (3.86 KB, patch)
2018-05-17 14:10 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2018-05-16 17:28:00 PDT
<rdar://problem/40230677>
Eric Carlson
Comment 2 2018-05-17 09:23:46 PDT
Created attachment 340591 [details] Patch
Jer Noble
Comment 3 2018-05-17 10:27:42 PDT
Comment on attachment 340591 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340591&action=review > Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:463 > + if (!protectedSelf->_callback) > return; > > - _callback->applicationWillEnterForeground(isSuspendedUnderLock); > + protectedSelf->_callback->applicationWillEnterForeground(isSuspendedUnderLock); Nit: this and the next 4 instances of this pattern could have a reversed if case: if (auto* callback = protectedSelf->callback) callback->applicationWillEnterForeground(isSuspendedUnderLock);
Eric Carlson
Comment 4 2018-05-17 11:26:56 PDT
Created attachment 340610 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-05-17 11:44:38 PDT
Comment on attachment 340610 [details] Patch for landing Clearing flags on attachment: 340610 Committed r231913: <https://trac.webkit.org/changeset/231913>
Eric Carlson
Comment 6 2018-05-17 14:10:05 PDT
Created attachment 340638 [details] Build fix.
WebKit Commit Bot
Comment 7 2018-05-17 14:48:54 PDT
Comment on attachment 340638 [details] Build fix. Clearing flags on attachment: 340638 Committed r231921: <https://trac.webkit.org/changeset/231921>
Note You need to log in before you can comment on or make changes to this bug.