Summary: | [iOS] Update AirPlay route monitoring | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||
Status: | ASSIGNED --- | ||||||||||
Severity: | Normal | CC: | commit-queue, jer.noble, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Other | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Eric Carlson
2018-05-16 17:26:46 PDT
Created attachment 340591 [details]
Patch
Comment on attachment 340591 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340591&action=review > Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:463 > + if (!protectedSelf->_callback) > return; > > - _callback->applicationWillEnterForeground(isSuspendedUnderLock); > + protectedSelf->_callback->applicationWillEnterForeground(isSuspendedUnderLock); Nit: this and the next 4 instances of this pattern could have a reversed if case: if (auto* callback = protectedSelf->callback) callback->applicationWillEnterForeground(isSuspendedUnderLock); Created attachment 340610 [details]
Patch for landing
Comment on attachment 340610 [details] Patch for landing Clearing flags on attachment: 340610 Committed r231913: <https://trac.webkit.org/changeset/231913> Created attachment 340638 [details]
Build fix.
Comment on attachment 340638 [details] Build fix. Clearing flags on attachment: 340638 Committed r231921: <https://trac.webkit.org/changeset/231921> |