Bug 185659

Summary: Layout Test animations/needs-layout.html is a flaky image failure
Product: WebKit Reporter: Dawei Fenton (:realdawei) <realdawei>
Component: AnimationsAssignee: Nobody <webkit-unassigned>
Status: REOPENED ---    
Severity: Normal CC: commit-queue, dino, fred.wang, graouts, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=172397
https://bugs.webkit.org/show_bug.cgi?id=187388
Attachments:
Description Flags
Mark test as flaky none

Description Dawei Fenton (:realdawei) 2018-05-15 15:03:21 PDT
The following layout test is flaky on macOS, most frequently on Debug WK2

animations/needs-layout.html

Probable cause:
Unknown, requires additional investigation

Flakiness Dashboard:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=animations%2Fneeds-layout.html

Link to image diff (showed a red rectangle that shouldn't have been there.
https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r231807%20(3282)/animations/needs-layout-diffs.html
Comment 1 Dawei Fenton (:realdawei) 2018-05-15 15:10:40 PDT
Antoine attempted to resolve flakiness in this test with the following commit:
https://trac.webkit.org/changeset/230703

However this test continues to be flaky.
Comment 2 Dawei Fenton (:realdawei) 2018-05-16 11:32:27 PDT
Created attachment 340507 [details]
Mark test as flaky
Comment 3 WebKit Commit Bot 2018-05-16 12:06:06 PDT
Comment on attachment 340507 [details]
Mark test as flaky

Clearing flags on attachment: 340507

Committed r231860: <https://trac.webkit.org/changeset/231860>
Comment 4 WebKit Commit Bot 2018-05-16 12:06:07 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-05-16 12:07:40 PDT
<rdar://problem/40302929>
Comment 6 Ryan Haddad 2018-05-16 12:30:40 PDT
Reopening since the patch was to mark the test as flaky.
Comment 7 Antoine Quint 2018-05-17 01:19:10 PDT
This test has been flaky before any work related to Web Animations had been ongoing it appears.