Bug 185650

Summary:

test262/Runner.pm: look for jsc in path if cannot call webkit-build-directory

Product:

WebKit

Reporter:

valerie <valerie>

Component:

JavaScriptCore

Assignee:

valerie <valerie>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, leo, msaboff, valerie, webkit-bug-importer, webkit-unassigned

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description valerie 2018-05-15 08:58:19 PDT

Some target environments require a look up of JSC in path before calling webkit-build-directory

Comment 1 valerie 2018-05-16 13:53:08 PDT

Actually, the order should be:
(1) use supplied --jsc
(2) if no supplied --jsc, look up via webkit-build-directory
(3) if local build of jsc not found, look for jsc in $PATH

Comment 2 valerie 2018-05-16 14:04:59 PDT

Created attachment 340523 [details]
Patch

Comment 3 valerie 2018-05-16 14:38:32 PDT

Created attachment 340525 [details]
Patch

Comment 4 Michael Saboff 2018-05-16 14:42:19 PDT

Comment on attachment 340525 [details]
Patch

r=me

Comment 5 WebKit Commit Bot 2018-05-16 15:20:18 PDT

Comment on attachment 340525 [details]
Patch

Rejecting attachment 340525 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 340525, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 231872 = 706d46f0f1bd1163625c7101063ce4f1045a3cd1
r231873 = 59ea49609addc35cb378d2da6804daf993730215
r231874 = a95a0156918bc81f56ed8ed8ac7c9c494131aa8e
r231875 = ee813fb2fa56c5109d9ab0d635cfc53ca012bb69
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/7702544

Comment 6 valerie 2018-05-17 08:53:24 PDT

Created attachment 340590 [details]
Patch

Comment 7 Michael Saboff 2018-05-17 09:40:29 PDT

Comment on attachment 340590 [details]
Patch

r=me

Comment 8 WebKit Commit Bot 2018-05-17 10:07:51 PDT

Comment on attachment 340590 [details]
Patch

Clearing flags on attachment: 340590

Committed r231908: <https://trac.webkit.org/changeset/231908>

Comment 9 WebKit Commit Bot 2018-05-17 10:07:53 PDT

All reviewed patches have been landed.  Closing bug.