Bug 185630

Summary:

Add an API test to guard against regressions while re-entering setDefersLoading:

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, ews-watchlist

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Brady Eidson

Reported 2018-05-14 14:48:11 PDT

Add an API test to guard against re-entering setDefersLoading: <rdar://problem/37033737>

Attachments
Patch (26.96 KB, patch) 2018-05-14 15:00 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (27.01 KB, patch) 2018-05-14 16:00 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (25.36 KB, patch) 2018-05-14 16:59 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2018-05-14 15:00:53 PDT

Created attachment 340364 [details] Patch

EWS Watchlist

Comment 2 2018-05-14 15:03:15 PDT

Attachment 340364 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm:89: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm:92: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 4 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 3 2018-05-14 16:00:45 PDT

Created attachment 340370 [details] Patch

EWS Watchlist

Comment 4 2018-05-14 16:02:37 PDT

Attachment 340370 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm:91: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm:94: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 5 2018-05-14 16:59:14 PDT

Created attachment 340379 [details] Patch

EWS Watchlist

Comment 6 2018-05-14 17:03:20 PDT

Attachment 340379 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm:91: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm:94: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 7 2018-05-14 20:09:24 PDT

Comment on attachment 340379 [details] Patch Clearing flags on attachment: 340379 Committed r231785: <https://trac.webkit.org/changeset/231785>

WebKit Commit Bot

Comment 8 2018-05-14 20:09:26 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.