Summary: | [Win][MiniBrowser] Create MainWindow even in transparent mode | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||||||
Component: | Tools / Tests | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, don.olmstead, lforschler, pvollan, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=58300 | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 184770 | ||||||||||||||
Attachments: |
|
Description
Fujii Hironori
2018-05-13 19:52:47 PDT
Created attachment 340283 [details]
transparent test HTML content
Created attachment 340284 [details]
[screenshot] after the fix
Created attachment 340285 [details]
Patch
Review, please. (In reply to Fujii Hironori from comment #2) > Created attachment 340284 [details] > [screenshot] after the fix What did this look like before the fix? It seems the main window is completely transparent in the screenshot, is that correct? Thank you very much for the feedback, Per. There is the screenshot of current implementations in Bug 58300. You are confused because the screenshot show the main window above the webview. In transparent mode, the webview is detached from the main window. They can be moved separately. I took the screenshot by moving the main window above the webview. Then, you think the main window is transparent. The main window has a menu bar, back and forward buttons, an URL field to control the webview. (In reply to Fujii Hironori from comment #6) > Thank you very much for the feedback, Per. > > There is the screenshot of current implementations in Bug 58300. > > You are confused because the screenshot show the main window above the > webview. > In transparent mode, the webview is detached from the main window. They can > be moved separately. > I took the screenshot by moving the main window above the webview. > Then, you think the main window is transparent. > > The main window has a menu bar, back and forward buttons, an URL field to > control the webview. Ah, I see. So this patch basically adds back and forward button in transparent mode? Created attachment 340617 [details]
[screenshot] before fix
Here's a screenshot of the current result for comparison. As can be seen it just has a white background rather than an actual transparent one.
(In reply to Don Olmstead from comment #8) > Here's a screenshot of the current result for comparison. Use —transparent switch. (In reply to Per Arne Vollan from comment #7) > > Ah, I see. So this patch basically adds back and forward button in > transparent mode? Right. Created attachment 340658 [details]
[screenshot] before fix
Comment on attachment 340285 [details]
Patch
R=me.
Comment on attachment 340285 [details] Patch Clearing flags on attachment: 340285 Committed r231964: <https://trac.webkit.org/changeset/231964> All reviewed patches have been landed. Closing bug. |