Bug 185597

Summary: [Win][MiniBrowser] Create MainWindow even in transparent mode
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: Tools / TestsAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, don.olmstead, lforschler, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=58300
Bug Depends on:    
Bug Blocks: 184770    
Attachments:
Description Flags
transparent test HTML content
none
[screenshot] after the fix
none
Patch
none
[screenshot] before fix
none
[screenshot] before fix none

Description Fujii Hironori 2018-05-13 19:52:47 PDT
[Win][MiniBrowser] Create MainWindow even in transparent mode

The MainWindow is not created in transparent mode.
The screenshot of current implementations is in Bug 58300.

There are two problems:

* Can't control the WebView. ie. going backward and forward.
* Can't quit the program
* It makes implementation complicated.
Comment 1 Fujii Hironori 2018-05-13 19:53:25 PDT
Created attachment 340283 [details]
transparent test HTML content
Comment 2 Fujii Hironori 2018-05-13 19:58:15 PDT
Created attachment 340284 [details]
[screenshot] after the fix
Comment 3 Fujii Hironori 2018-05-13 20:12:11 PDT
Created attachment 340285 [details]
Patch
Comment 4 Fujii Hironori 2018-05-15 04:04:29 PDT
Review, please.
Comment 5 Per Arne Vollan 2018-05-16 20:12:24 PDT
(In reply to Fujii Hironori from comment #2)
> Created attachment 340284 [details]
> [screenshot] after the fix

What did this look like before the fix? It seems the main window is completely transparent in the screenshot, is that correct?
Comment 6 Fujii Hironori 2018-05-16 20:31:11 PDT
Thank you very much for the feedback, Per.

There is the screenshot of current implementations in Bug 58300.

You are confused because the screenshot show the main window above the webview.
In transparent mode, the webview is detached from the main window. They can be moved separately.
I took the screenshot by moving the main window above the webview.
Then, you think the main window is transparent.

The main window has a menu bar, back and forward buttons, an URL field to control the webview.
Comment 7 Per Arne Vollan 2018-05-17 07:05:02 PDT
(In reply to Fujii Hironori from comment #6)
> Thank you very much for the feedback, Per.
> 
> There is the screenshot of current implementations in Bug 58300.
> 
> You are confused because the screenshot show the main window above the
> webview.
> In transparent mode, the webview is detached from the main window. They can
> be moved separately.
> I took the screenshot by moving the main window above the webview.
> Then, you think the main window is transparent.
> 
> The main window has a menu bar, back and forward buttons, an URL field to
> control the webview.

Ah, I see. So this patch basically adds back and forward button in transparent mode?
Comment 8 Don Olmstead 2018-05-17 11:55:24 PDT
Created attachment 340617 [details]
[screenshot] before fix

Here's a screenshot of the current result for comparison. As can be seen it just has a white background rather than an actual transparent one.
Comment 9 Fujii Hironori 2018-05-17 15:03:26 PDT
(In reply to Don Olmstead from comment #8)
> Here's a screenshot of the current result for comparison. 

Use —transparent switch.
Comment 10 Fujii Hironori 2018-05-17 15:04:41 PDT
(In reply to Per Arne Vollan from comment #7)
> 
> Ah, I see. So this patch basically adds back and forward button in
> transparent mode?

Right.
Comment 11 Don Olmstead 2018-05-17 15:08:29 PDT
Created attachment 340658 [details]
[screenshot] before fix
Comment 12 Per Arne Vollan 2018-05-18 07:28:04 PDT
Comment on attachment 340285 [details]
Patch

R=me.
Comment 13 WebKit Commit Bot 2018-05-18 10:36:32 PDT
Comment on attachment 340285 [details]
Patch

Clearing flags on attachment: 340285

Committed r231964: <https://trac.webkit.org/changeset/231964>
Comment 14 WebKit Commit Bot 2018-05-18 10:36:34 PDT
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2018-05-18 10:38:22 PDT
<rdar://problem/40369786>