Bug 185597

Summary: [Win][MiniBrowser] Create MainWindow even in transparent mode
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: Tools / TestsAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, don.olmstead, lforschler, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=58300
Bug Depends on:    
Bug Blocks: 184770    
Attachments:
Description Flags
transparent test HTML content
none
[screenshot] after the fix
none
Patch
none
[screenshot] before fix
none
[screenshot] before fix none

Fujii Hironori
Reported 2018-05-13 19:52:47 PDT
[Win][MiniBrowser] Create MainWindow even in transparent mode The MainWindow is not created in transparent mode. The screenshot of current implementations is in Bug 58300. There are two problems: * Can't control the WebView. ie. going backward and forward. * Can't quit the program * It makes implementation complicated.
Attachments
transparent test HTML content (312 bytes, text/html)
2018-05-13 19:53 PDT, Fujii Hironori 		no flags
Details
[screenshot] after the fix (210.31 KB, image/png)
2018-05-13 19:58 PDT, Fujii Hironori 		no flags
Details
Patch (4.79 KB, patch)
2018-05-13 20:12 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
[screenshot] before fix (8.21 KB, image/png)
2018-05-17 11:55 PDT, Don Olmstead 		no flags
Details
[screenshot] before fix (191.92 KB, image/png)
2018-05-17 15:08 PDT, Don Olmstead 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-05-13 19:53:25 PDT
Created attachment 340283 [details] transparent test HTML content
Fujii Hironori
Comment 2 2018-05-13 19:58:15 PDT
Created attachment 340284 [details] [screenshot] after the fix
Fujii Hironori
Comment 3 2018-05-13 20:12:11 PDT
Created attachment 340285 [details] Patch
Fujii Hironori
Comment 4 2018-05-15 04:04:29 PDT
Review, please.
Per Arne Vollan
Comment 5 2018-05-16 20:12:24 PDT
(In reply to Fujii Hironori from comment #2) > Created attachment 340284 [details] > [screenshot] after the fix What did this look like before the fix? It seems the main window is completely transparent in the screenshot, is that correct?
Fujii Hironori
Comment 6 2018-05-16 20:31:11 PDT
Thank you very much for the feedback, Per. There is the screenshot of current implementations in Bug 58300. You are confused because the screenshot show the main window above the webview. In transparent mode, the webview is detached from the main window. They can be moved separately. I took the screenshot by moving the main window above the webview. Then, you think the main window is transparent. The main window has a menu bar, back and forward buttons, an URL field to control the webview.
Per Arne Vollan
Comment 7 2018-05-17 07:05:02 PDT
(In reply to Fujii Hironori from comment #6) > Thank you very much for the feedback, Per. > > There is the screenshot of current implementations in Bug 58300. > > You are confused because the screenshot show the main window above the > webview. > In transparent mode, the webview is detached from the main window. They can > be moved separately. > I took the screenshot by moving the main window above the webview. > Then, you think the main window is transparent. > > The main window has a menu bar, back and forward buttons, an URL field to > control the webview. Ah, I see. So this patch basically adds back and forward button in transparent mode?
Don Olmstead
Comment 8 2018-05-17 11:55:24 PDT
Created attachment 340617 [details] [screenshot] before fix Here's a screenshot of the current result for comparison. As can be seen it just has a white background rather than an actual transparent one.
Fujii Hironori
Comment 9 2018-05-17 15:03:26 PDT
(In reply to Don Olmstead from comment #8) > Here's a screenshot of the current result for comparison. Use —transparent switch.
Fujii Hironori
Comment 10 2018-05-17 15:04:41 PDT
(In reply to Per Arne Vollan from comment #7) > > Ah, I see. So this patch basically adds back and forward button in > transparent mode? Right.
Don Olmstead
Comment 11 2018-05-17 15:08:29 PDT
Created attachment 340658 [details] [screenshot] before fix
Per Arne Vollan
Comment 12 2018-05-18 07:28:04 PDT
Comment on attachment 340285 [details] Patch R=me.
WebKit Commit Bot
Comment 13 2018-05-18 10:36:32 PDT
Comment on attachment 340285 [details] Patch Clearing flags on attachment: 340285 Committed r231964: <https://trac.webkit.org/changeset/231964>
WebKit Commit Bot
Comment 14 2018-05-18 10:36:34 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 15 2018-05-18 10:38:22 PDT
<rdar://problem/40369786>
Note You need to log in before you can comment on or make changes to this bug.