Bug 185565

Summary: Test262: Fix legacy CRLF eol
Product: WebKit Reporter: Leo Balter <leo>
Component: New BugsAssignee: Leo Balter <leo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, msaboff, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews205 for win-future
none
Patch none

Leo Balter
Reported 2018-05-11 14:47:45 PDT
Test262: Update skip list from tests results
Attachments
Patch (2.42 KB, patch)
2018-05-11 14:50 PDT, Leo Balter 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews205 for win-future (12.74 MB, application/zip)
2018-05-11 17:06 PDT, EWS Watchlist 		no flags
Details
Patch (2.15 KB, patch)
2018-05-14 09:59 PDT, Leo Balter 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Leo Balter
Comment 1 2018-05-11 14:50:36 PDT
Created attachment 340225 [details] Patch
Leo Balter
Comment 2 2018-05-11 14:51:34 PDT
I already checked the CRLF fix is not being reverted when we re-import Test262 anymore. See patch desc for more information on this issue.
EWS Watchlist
Comment 3 2018-05-11 17:06:38 PDT
Comment on attachment 340225 [details] Patch Attachment 340225 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7655745 New failing tests: http/tests/security/canvas-remote-read-remote-video-redirect.html
EWS Watchlist
Comment 4 2018-05-11 17:06:50 PDT
Created attachment 340233 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Yusuke Suzuki
Comment 5 2018-05-13 12:08:17 PDT
Comment on attachment 340225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340225&action=review > JSTests/test262/config.yaml:6 > + paths: > + - time-clip-to-integer.js # https://bugs.webkit.org/show_bug.cgi?id=185563 This change is unnecessary now since it is fixed.
Leo Balter
Comment 6 2018-05-14 07:17:01 PDT
Yusuke, so does this means we can close Bug 185563?
Yusuke Suzuki
Comment 7 2018-05-14 07:36:09 PDT
(In reply to Leo Balter from comment #6) > Yusuke, so does this means we can close Bug 185563? Yeah
Leo Balter
Comment 8 2018-05-14 08:03:26 PDT
Thanks! I just checked with a new build and I can confirm it's fixed, probably by the Bug 185578. I'll try to rebase this patch to only ship the CRLF fix, if that's ok.
Leo Balter
Comment 9 2018-05-14 09:59:47 PDT
Created attachment 340324 [details] Patch
Leo Balter
Comment 10 2018-05-14 10:01:26 PDT
Done! Now I only left the path (and the respective bug ref) in the config file so it can be used as an example for further additions. I renamed this Bug to match the latest patch.
Yusuke Suzuki
Comment 11 2018-05-14 10:01:36 PDT
Comment on attachment 340324 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340324&action=review > JSTests/test262/config.yaml:6 > + # - time-clip-to-integer.js # https://bugs.webkit.org/show_bug.cgi?id=185563 I think this line is unnecessary.
Yusuke Suzuki
Comment 12 2018-05-14 10:02:00 PDT
(In reply to Leo Balter from comment #10) > Done! Now I only left the path (and the respective bug ref) in the config > file so it can be used as an example for further additions. > > I renamed this Bug to match the latest patch. Ah, OK.
WebKit Commit Bot
Comment 13 2018-05-14 10:39:21 PDT
Comment on attachment 340324 [details] Patch Clearing flags on attachment: 340324 Committed r231764: <https://trac.webkit.org/changeset/231764>
WebKit Commit Bot
Comment 14 2018-05-14 10:39:22 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 15 2018-05-14 10:41:18 PDT
<rdar://problem/40223130>
Note You need to log in before you can comment on or make changes to this bug.