| Summary: | Test262: Fix legacy CRLF eol | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Leo Balter <leo> | ||||||||
| Component: | New Bugs | Assignee: | Leo Balter <leo> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, msaboff, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Leo Balter
2018-05-11 14:47:45 PDT
Created attachment 340225 [details]
Patch
I already checked the CRLF fix is not being reverted when we re-import Test262 anymore. See patch desc for more information on this issue. Comment on attachment 340225 [details] Patch Attachment 340225 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7655745 New failing tests: http/tests/security/canvas-remote-read-remote-video-redirect.html Created attachment 340233 [details]
Archive of layout-test-results from ews205 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 340225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340225&action=review > JSTests/test262/config.yaml:6 > + paths: > + - time-clip-to-integer.js # https://bugs.webkit.org/show_bug.cgi?id=185563 This change is unnecessary now since it is fixed. Yusuke, so does this means we can close Bug 185563? (In reply to Leo Balter from comment #6) > Yusuke, so does this means we can close Bug 185563? Yeah Thanks! I just checked with a new build and I can confirm it's fixed, probably by the Bug 185578. I'll try to rebase this patch to only ship the CRLF fix, if that's ok. Created attachment 340324 [details]
Patch
Done! Now I only left the path (and the respective bug ref) in the config file so it can be used as an example for further additions. I renamed this Bug to match the latest patch. Comment on attachment 340324 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340324&action=review > JSTests/test262/config.yaml:6 > + # - time-clip-to-integer.js # https://bugs.webkit.org/show_bug.cgi?id=185563 I think this line is unnecessary. (In reply to Leo Balter from comment #10) > Done! Now I only left the path (and the respective bug ref) in the config > file so it can be used as an example for further additions. > > I renamed this Bug to match the latest patch. Ah, OK. Comment on attachment 340324 [details] Patch Clearing flags on attachment: 340324 Committed r231764: <https://trac.webkit.org/changeset/231764> All reviewed patches have been landed. Closing bug. |