Summary: | [EME][GStreamer] Handle the protection event in MediaPlayerPrivate | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yacine Bandou <bandou.yacine> | ||||||||
Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | calvaris, commit-queue, olivier.blin, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 185245 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Yacine Bandou
2018-05-10 16:45:13 PDT
Created attachment 340149 [details]
Patch
Comment on attachment 340149 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340149&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:1217 > + if (m_cdmInstance && strcmp(GStreamerEMEUtilities::keySystemToUuid(m_cdmInstance->keySystem()), eventKeySystemUUID)) Better to use g_strcmp0. It would be interesting to add a GST_TRACE or DEBUG comment for the bail out here. Created attachment 340182 [details]
Patch
Comment on attachment 340182 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340182&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:1216 > + // Palyread, so we ignore this event. PlayReady Comment on attachment 340182 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340182&action=review > Source/WebCore/ChangeLog:11 > + It adds a handler for the protection event in MediaPalyerPrivate, it extracts the InitData from the event MediaPlayerPrivateGStreamerBase. Created attachment 340184 [details]
Patch
Comment on attachment 340184 [details] Patch Clearing flags on attachment: 340184 Committed r231699: <https://trac.webkit.org/changeset/231699> All reviewed patches have been landed. Closing bug. |