Bug 185533

Summary: build-webkit can erroneously warn about Xcode being too old
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, dbates, ews-watchlist, ggaren, lforschler, mitz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug none

Ryosuke Niwa
Reported 2018-05-10 16:09:56 PDT
Fix that.
Attachments
Fixes the bug (1.18 KB, patch)
2018-05-10 16:12 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-05-10 16:12:47 PDT
Created attachment 340143 [details] Fixes the bug
mitz
Comment 2 2018-05-10 16:17:18 PDT
Comment on attachment 340143 [details] Fixes the bug Seems OK, but I doubt that the mechanism that the Xcode version check that uses this is correct.
WebKit Commit Bot
Comment 3 2018-05-10 17:06:38 PDT
Comment on attachment 340143 [details] Fixes the bug Clearing flags on attachment: 340143 Committed r231677: <https://trac.webkit.org/changeset/231677>
WebKit Commit Bot
Comment 4 2018-05-10 17:06:40 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-05-10 17:11:01 PDT
<rdar://problem/40147925>
Note You need to log in before you can comment on or make changes to this bug.