Bug 185528

Summary: [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, don.olmstead, ews-watchlist, lforschler, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ross Kirsling
Reported 2018-05-10 14:01:15 PDT
[WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
Attachments
Patch (2.50 KB, patch)
2018-05-10 14:01 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2018-05-10 14:01:38 PDT
Created attachment 340126 [details] Patch
EWS Watchlist
Comment 2 2018-05-10 14:03:04 PDT
Attachment 340126 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:85: [TestFactory.__init__] Undefined variable 'InstallWinCairoDependencies' [pylint/E0602] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ross Kirsling
Comment 3 2018-05-10 14:04:38 PDT
`build-webkit` does this automatically: https://github.com/WebKit/webkit/blob/master/Tools/Scripts/build-webkit#L242-L243 But the test bot, of course, runs `--no-build`, so we need to actually ask for the dependencies.
Ross Kirsling
Comment 4 2018-05-10 14:06:57 PDT
Style error should be a mistake...?
WebKit Commit Bot
Comment 5 2018-05-10 16:14:58 PDT
Comment on attachment 340126 [details] Patch Clearing flags on attachment: 340126 Committed r231673: <https://trac.webkit.org/changeset/231673>
WebKit Commit Bot
Comment 6 2018-05-10 16:14:59 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-05-10 16:15:37 PDT
<rdar://problem/40146077>
Note You need to log in before you can comment on or make changes to this bug.