Bug 185527

Summary:

Exception in bot watcher's dashboard if a hidden platform in no longer configured for display

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, commit-queue, ews-watchlist, lforschler, ryanhaddad, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	none
proposed fix	none

Description Alexey Proskuryakov 2018-05-10 13:29:20 PDT

We store hidden platforms in local storage, so we cannot expect that these platforms are valid with regards to currently running code.

Comment 1 Alexey Proskuryakov 2018-05-10 13:30:25 PDT

Created attachment 340122 [details]
proposed fix

Comment 2 EWS Watchlist 2018-05-10 13:33:27 PDT

Attachment 340122 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:134:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Alexey Proskuryakov 2018-05-10 13:42:25 PDT

Created attachment 340123 [details]
proposed fix

Oops, tab.

Comment 4 WebKit Commit Bot 2018-11-29 15:51:33 PST

Comment on attachment 340123 [details]
proposed fix

Clearing flags on attachment: 340123

Committed r238704: <https://trac.webkit.org/changeset/238704>

Comment 5 WebKit Commit Bot 2018-11-29 15:51:34 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 Radar WebKit Bug Importer 2018-11-29 15:52:40 PST

<rdar://problem/46357482>