Bug 185527

Summary: Exception in bot watcher's dashboard if a hidden platform in no longer configured for display
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, ews-watchlist, lforschler, ryanhaddad, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix
none
proposed fix none

Alexey Proskuryakov
Reported 2018-05-10 13:29:20 PDT
We store hidden platforms in local storage, so we cannot expect that these platforms are valid with regards to currently running code.
Attachments
proposed fix (1.47 KB, patch)
2018-05-10 13:30 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed fix (1.48 KB, patch)
2018-05-10 13:42 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2018-05-10 13:30:25 PDT
Created attachment 340122 [details] proposed fix
EWS Watchlist
Comment 2 2018-05-10 13:33:27 PDT
Attachment 340122 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:134: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3 2018-05-10 13:42:25 PDT
Created attachment 340123 [details] proposed fix Oops, tab.
WebKit Commit Bot
Comment 4 2018-11-29 15:51:33 PST
Comment on attachment 340123 [details] proposed fix Clearing flags on attachment: 340123 Committed r238704: <https://trac.webkit.org/changeset/238704>
WebKit Commit Bot
Comment 5 2018-11-29 15:51:34 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-11-29 15:52:40 PST
<rdar://problem/46357482>
Note You need to log in before you can comment on or make changes to this bug.