Bug 185479

Summary: [GStreamer] Fix style issue in MediaPlayerPrivateGStreamer
Product: WebKit Reporter: Thibault Saunier <tsaunier>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, pnormand, tsaunier, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[GStreamer] Fix style issue in MediaPlayerPrivateGStreamer none

Thibault Saunier
Reported 2018-05-09 11:09:44 PDT
Several fixable issue happen when running check-webkit-style explicitely against the file.
Attachments
[GStreamer] Fix style issue in MediaPlayerPrivateGStreamer (10.80 KB, patch)
2018-05-09 11:17 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thibault Saunier
Comment 1 2018-05-09 11:17:31 PDT
Created attachment 339990 [details] [GStreamer] Fix style issue in MediaPlayerPrivateGStreamer ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:114: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:194: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:398: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:440: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:806: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:869: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:880: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:940: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1102: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1109: Multi line control clauses should use braces. [whitespace/braces] [4]
WebKit Commit Bot
Comment 2 2018-05-09 12:01:50 PDT
Comment on attachment 339990 [details] [GStreamer] Fix style issue in MediaPlayerPrivateGStreamer Clearing flags on attachment: 339990 Committed r231581: <https://trac.webkit.org/changeset/231581>
WebKit Commit Bot
Comment 3 2018-05-09 12:01:51 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-05-09 12:03:24 PDT
<rdar://problem/40101037>
Note You need to log in before you can comment on or make changes to this bug.