Bug 185456

Summary: Replace multiple Watchpoint Set fireAll() methods with templates
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Michael Saboff
Reported 2018-05-08 16:42:20 PDT
There are multiple fireAll() methods with the same logic taking slightly different parameters in both WatchpointSet and InlineWatchpointSet. These can be simplified with templated methods.
Attachments
Patch (3.06 KB, patch)
2018-05-08 16:47 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2018-05-08 16:47:24 PDT
Created attachment 339899 [details] Patch
WebKit Commit Bot
Comment 2 2018-05-08 18:11:45 PDT
Comment on attachment 339899 [details] Patch Clearing flags on attachment: 339899 Committed r231534: <https://trac.webkit.org/changeset/231534>
WebKit Commit Bot
Comment 3 2018-05-08 18:11:47 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-05-08 18:12:20 PDT
<rdar://problem/40078983>
Note You need to log in before you can comment on or make changes to this bug.