| Summary: | Consecutive messages logged as JSON are coalesced | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||||
| Component: | Web Inspector | Assignee: | Eric Carlson <eric.carlson> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | Other | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Eric Carlson
2018-05-08 11:12:03 PDT
Created attachment 339847 [details]
Patch
Comment on attachment 339847 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339847&action=review r=me > LayoutTests/inspector/console/webcore-logging.html:165 > + name: "Console.Logging.LogAsJSON", Maybe this should mention not repeating? Console.Logging.LogAsJSONWithoutRepeat" > LayoutTests/inspector/console/webcore-logging.html:192 > + if (++messageCount == 3) { Style: We prefer `===` where possible, but tests we can be lenient on style. Feel free to cq as is. Comment on attachment 339847 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339847&action=review >> LayoutTests/inspector/console/webcore-logging.html:165 >> + name: "Console.Logging.LogAsJSON", > > Maybe this should mention not repeating? Console.Logging.LogAsJSONWithoutRepeat" Good idea, fixed. >> LayoutTests/inspector/console/webcore-logging.html:192 >> + if (++messageCount == 3) { > > Style: We prefer `===` where possible, but tests we can be lenient on style. Feel free to cq as is. Fixed. Created attachment 339875 [details]
Patch for landing
Comment on attachment 339875 [details] Patch for landing Rejecting attachment 339875 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 339875, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/7612099 Created attachment 339877 [details]
Patch for landing
Comment on attachment 339877 [details] Patch for landing Clearing flags on attachment: 339877 Committed r231515: <https://trac.webkit.org/changeset/231515> Comment on attachment 339877 [details] Patch for landing Attachment 339877 [details] did not pass jsc-ews (mac): Output: http://webkit-queues.webkit.org/results/7613073 New failing tests: stress/ftl-put-by-id-setter-exception-interesting-live-state.js.dfg-eager-no-cjit-validate Comment on attachment 339877 [details] Patch for landing Attachment 339877 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7619200 New failing tests: http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html Created attachment 339924 [details]
Archive of layout-test-results from ews201 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
This had landed: <https://trac.webkit.org/changeset/231515/webkit> |