Bug 185432 – Consecutive messages logged as JSON are coalesced

• Component: Web Inspector
• Status: RESOLVED FIXED

[Eric Carlson]

ConsoleMessage::isEqual returns true for two messages with the same arguments but different JSON arguments, so they are coalesced.

[Eric Carlson]

Created attachment 339847 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/40065321>

[Joseph Pecoraro]

Comment on attachment 339847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339847&action=review

r=me

> LayoutTests/inspector/console/webcore-logging.html:165
> +        name: "Console.Logging.LogAsJSON",

Maybe this should mention not repeating? Console.Logging.LogAsJSONWithoutRepeat"

> LayoutTests/inspector/console/webcore-logging.html:192
> +                        if (++messageCount == 3) {

Style: We prefer `===` where possible, but tests we can be lenient on style. Feel free to cq as is.

[Eric Carlson]

Comment on attachment 339847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339847&action=review

>> LayoutTests/inspector/console/webcore-logging.html:165
>> +        name: "Console.Logging.LogAsJSON",
> 
> Maybe this should mention not repeating? Console.Logging.LogAsJSONWithoutRepeat"

Good idea, fixed.

>> LayoutTests/inspector/console/webcore-logging.html:192
>> +                        if (++messageCount == 3) {
> 
> Style: We prefer `===` where possible, but tests we can be lenient on style. Feel free to cq as is.

Fixed.

[Eric Carlson]

Created attachment 339875 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 339875 [details]
Patch for landing

Rejecting attachment 339875 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 339875, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/7612099

[Eric Carlson]

Created attachment 339877 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 339877 [details]
Patch for landing

Clearing flags on attachment: 339877

Committed r231515: <https://trac.webkit.org/changeset/231515>

[EWS Watchlist]

Comment on attachment 339877 [details]
Patch for landing

Attachment 339877 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/7613073

New failing tests:
stress/ftl-put-by-id-setter-exception-interesting-live-state.js.dfg-eager-no-cjit-validate

[EWS Watchlist]

Comment on attachment 339877 [details]
Patch for landing

Attachment 339877 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7619200

New failing tests:
http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html

[EWS Watchlist]

Created attachment 339924 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Joseph Pecoraro]

This had landed:
<https://trac.webkit.org/changeset/231515/webkit>