Bug 185395

Summary:

test262/Runner.pm: --failing-files uses results file not expectations

Product:

WebKit

Reporter:

valerie <valerie>

Component:

JavaScriptCore

Assignee:

valerie <valerie>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, leo, msaboff, valerie, webkit-bug-importer, webkit-unassigned

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews202 for win-future	none

valerie

Reported 2018-05-07 15:04:23 PDT

Motivation: Developers might want to run ONLY the failing files of their most recent run. Results from the most recent run are save in the results/results.yaml file. Previous to this patch, the command line option --failing-files re-ran the failing files from the expectation file. But this expectation file is only re-created when committing a file that changes the expected failures, it is not re-created during local development work flow and testing.

Attachments
Patch (7.95 KB, patch) 2018-05-08 19:25 PDT, valerie	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews202 for win-future (12.84 MB, application/zip) 2018-05-09 00:50 PDT, EWS Watchlist	no flags	Details
View All Add attachment proposed patch, testcase, etc.

valerie

Comment 1 2018-05-08 10:15:39 PDT

This patch also allows for users to supply an expectations file different than the default, and updates some relevant warnings or errors.

valerie

Comment 2 2018-05-08 19:25:43 PDT

Created attachment 339917 [details] Patch

EWS Watchlist

Comment 3 2018-05-09 00:49:54 PDT

Comment on attachment 339917 [details] Patch Attachment 339917 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7620856 New failing tests: http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html

EWS Watchlist

Comment 4 2018-05-09 00:50:05 PDT

Created attachment 339940 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Michael Saboff

Comment 5 2018-05-09 13:53:21 PDT

Comment on attachment 339917 [details] Patch r=me

WebKit Commit Bot

Comment 6 2018-05-10 10:37:48 PDT

Comment on attachment 339917 [details] Patch Clearing flags on attachment: 339917 Committed r231644: <https://trac.webkit.org/changeset/231644>

WebKit Commit Bot

Comment 7 2018-05-10 10:37:49 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.