Bug 185393

Summary:

Abstract logic to log console messages and send CSP violation reports into a client

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cdumez, esprehn+autocc, ews-watchlist, japhet, kangil.han, mkwst, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

Bug Depends on:

185366, 185380

Bug Blocks:

185410

Attachments:

Description	Flags
Patch	bfulgham: review+
For EWS	none

Daniel Bates

Reported 2018-05-07 14:11:25 PDT

Towards supporting logging of console messages for CSP parse errors and CSP violations as well as the sending of CSP reports from NetworkProcess and workers we should abstract the logic to perform these operations into a client the the ContentSecurityPolicy object can delegate to.

Attachments
Patch (44.93 KB, patch) 2018-05-07 15:32 PDT, Daniel Bates	bfulgham: review+	Details Formatted Diff Diff
For EWS (42.27 KB, patch) 2018-05-07 18:16 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-05-07 14:12:26 PDT

<rdar://problem/40036053>

Daniel Bates

Comment 2 2018-05-07 15:32:19 PDT

Created attachment 339760 [details] Patch This patch depends on the patches for bug 185366 and bug 185380.

Brent Fulgham

Comment 3 2018-05-07 16:25:34 PDT

Comment on attachment 339760 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339760&action=review r=me > Source/WebKit/NetworkProcess/NetworkLoadChecker.h:77 > + WebCore::ContentSecurityPolicy* contentSecurityPolicy(); Perhaps m_contentSecurityPolicy doesn't need to be mutable if this can be non-const.

EWS Watchlist

Comment 4 2018-05-07 16:42:31 PDT

Attachment 339760 [details] did not pass style-queue: ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:94: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Daniel Bates

Comment 5 2018-05-07 18:16:11 PDT

Created attachment 339785 [details] For EWS

EWS Watchlist

Comment 6 2018-05-07 18:19:01 PDT

Attachment 339785 [details] did not pass style-queue: ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:94: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Daniel Bates

Comment 7 2018-05-07 20:51:13 PDT

Committed r231476: <https://trac.webkit.org/changeset/231476>

Note You need to log in before you can comment on or make changes to this bug.