Bug 185384 – Layout Test webrtc/addICECandidate-closed.html is a flaky failure

• Component: WebRTC
• Status: RESOLVED FIXED

[Ryan Haddad]

The following layout test is flaky on [insert platform]

webrtc/addICECandidate-closed.html

Probable cause:

The test was a flaky timeout until https://bugs.webkit.org/show_bug.cgi?id=185336, now it is a flaky failure.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2FaddICECandidate-closed.html

--- /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test-results/webrtc/addICECandidate-closed-expected.txt
+++ /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test-results/webrtc/addICECandidate-closed-actual.txt
@@ -1,3 +1,5 @@
+
+Harness Error (FAIL), message = The object is in an invalid state.
 
 PASS Close a peer connection in the middle of gathering

[youenn fablet]

Created attachment 339733 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 339733 [details]
Patch

Clearing flags on attachment: 339733

Committed r231453: <https://trac.webkit.org/changeset/231453>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40035167>

[Ryan Haddad]

This test is still flaky.

[youenn fablet]

Thanks Ryan.
I will look at it tomorrow. If it causes issues, please mark it as flaky.

[Alexey Proskuryakov]

Youenn, have you had a chance to take a look?

[youenn fablet]

Created attachment 340175 [details]
Patch

[EWS Watchlist]

Comment on attachment 340175 [details]
Patch

Attachment 340175 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7649963

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html

[EWS Watchlist]

Created attachment 340187 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[youenn fablet]

Comment on attachment 340175 [details]
Patch

win error is unrelated

[WebKit Commit Bot]

Comment on attachment 340175 [details]
Patch

Clearing flags on attachment: 340175

Committed r231706: <https://trac.webkit.org/changeset/231706>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[youenn fablet]

Reopening to attach new patch.

[youenn fablet]

Created attachment 340465 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 340465 [details]
Patch

Rejecting attachment 340465 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 340465, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
    -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 231854 = 7d59af35259c966bc32d56c73d12ab544175de4c
r231859 = 06e29dfb196800bec18d20487cfb000018ac7be9
r231860 = 2ac211f9b76f858acba7c92721d9e84ac683b239
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/7700452

[WebKit Commit Bot]

Comment on attachment 340465 [details]
Patch

Clearing flags on attachment: 340465

Committed r231865: <https://trac.webkit.org/changeset/231865>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.