Bug 185378 – [GTK] SoupNetworkSession.h:68:62: error: unknown type name 'URL'

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Antoine Jacoutot]

Hi.

When trying to build WebKitGTK 2.20.2 on OpenBSD amd64, I am running into the following error:

In file included from DerivedSources/WebKit/unified-sources/UnifiedSource59.cpp:2:                                                                                                                In file included from /hack/objdirs/pobj/webkitgtk4-2.20.2/webkitgtk-2.20.2/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp:32:                                                                In file included from DerivedSources/ForwardingHeaders/WebCore/SoupNetworkSession.h:1:                                                                                                            /hack/objdirs/pobj/webkitgtk4-2.20.2/webkitgtk-2.20.2/Source/WebCore/platform/network/soup/SoupNetworkSession.h:68:62: error: unknown type name 'URL'                                                 static std::optional<ResourceError> checkTLSErrors(const URL&, GTlsCertificate*, GTlsCertificateFlags);                                                                                                                                                    ^                                                                                                                                    1 error generated.

[Michael Catanzaro]

Happens on Linux too

[Thomas Klausner]

And on NetBSD.

[Antoine Jacoutot]

Did any of you guys find a workaround for this? (besides reverting the commit)
Thanks.

[Michael Catanzaro]

Just #include "URL.h" and submit a patch if that fixes it for you.

[Thomas Klausner]

Created attachment 340358 [details]
Patch fixing the problem.

The patch follows a suggestion by Michael Catanzaro, and fixes the problem for me.

[Adrian Perez]

Patch looks good to me. I have submitted to patch to the EWS, and
if it builds fine there, I think we should land this.

[EWS Watchlist]

Attachment 340358 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/soup/SoupNetworkSession.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adrian Perez]

Comment on attachment 340358 [details]
Patch fixing the problem.

View in context: https://bugs.webkit.org/attachment.cgi?id=340358&action=review

> Source/WebCore/platform/network/soup/SoupNetworkSession.h:35
> +#include <URL.h>

Could you please sort the #include lines alphabetically and re-submit?
In WebKit we try to keep them always sorted, unless there is some technical
reason why that is not possible. Thanks in advance!

[Michael Catanzaro]

Please also add a changelog entry with Tools/Scripts/prepare-ChangeLog -b 185378 if you want credit, otherwise I'll just push this.

[Michael Catanzaro]

(with the include in the right place, yes)

[EWS Watchlist]

Comment on attachment 340358 [details]
Patch fixing the problem.

Attachment 340358 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7682352

New failing tests:
transitions/interrupted-transition-hardware.html

[EWS Watchlist]

Created attachment 340372 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[EWS Watchlist]

Comment on attachment 340358 [details]
Patch fixing the problem.

Attachment 340358 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7684602

New failing tests:
http/tests/security/canvas-remote-read-remote-video-localhost.html

[EWS Watchlist]

Created attachment 340388 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Thomas Klausner]

Created attachment 340398 [details]
Updated patch.

Updated patch, headers sorted like suggested.
Also includes a Changelog entry.
Thanks for the feedback!

[Antoine Jacoutot]

Created attachment 340399 [details]
include sorted alphabetically

Works for me on OpenBSD.

[EWS Watchlist]

Attachment 340398 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/soup/SoupNetworkSession.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Thomas Klausner]

Created attachment 340411 [details]
Next try at conformant patch.

Patch with headers in ASCII sort order instead of in natural language sort order, hope this passes the style checker now.

[Michael Catanzaro]

Comment on attachment 340411 [details]
Next try at conformant patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=340411&action=review

> Source/WebCore/platform/network/soup/SoupNetworkSession.h:29
> +#include <URL.h>

It's going to complain that you didn't use "quotes". I'll fix that before landing.

[Michael Catanzaro]

Created attachment 340415 [details]
Patch

[Michael Catanzaro]

Committed r231804: <https://trac.webkit.org/changeset/231804>

[Carlos Garcia Campos]

Comment on attachment 340415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340415&action=review

> Source/WebCore/platform/network/soup/SoupNetworkSession.h:29
> +#include "URL.h"

Do we really need to include it in the header? I think we can forward declare it by adding class URL below and include it in the cpp.

[Michael Catanzaro]

You're right, sorry for not checking that first.

[Michael Catanzaro]

Committed r231876: <https://trac.webkit.org/changeset/231876>