Bug 185353

Summary: Text track cue logging should include cue text
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, calvaris, cdumez, commit-queue, esprehn+autocc, ews-watchlist, gyuyoung.kim, jer.noble, philipj, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
none
Patch
none
Patch for landing.
none
Only log cue text in debug build none

Eric Carlson
Reported 2018-05-05 10:39:04 PDT
Text track cue logging should include cue text
Attachments
Proposed patch (4.22 KB, patch)
2018-05-05 15:10 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (4.52 KB, patch)
2018-05-05 20:33 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing. (5.12 KB, patch)
2018-05-07 08:09 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Only log cue text in debug build (3.22 KB, patch)
2018-05-07 14:34 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-05-05 10:39:30 PDT
<rdar://problem/40003565>
Eric Carlson
Comment 2 2018-05-05 15:10:41 PDT
Created attachment 339657 [details] Proposed patch
Eric Carlson
Comment 3 2018-05-05 20:33:58 PDT
Created attachment 339667 [details] Patch
youenn fablet
Comment 4 2018-05-06 21:02:40 PDT
Comment on attachment 339667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339667&action=review > Source/WebCore/html/track/VTTCue.h:180 > + void toJSON(JSON::Object&) const final; Could be made private maybe? > Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h:123 > + object->setString("text", m_content); ASCIILiteral? > Source/WebCore/platform/graphics/iso/ISOVTTCue.cpp:117 > + object->setString(ASCIILiteral("text"), m_cueText); Should it be "cueText"? Similarly for "text" -> "content" above maybe?
Eric Carlson
Comment 5 2018-05-07 08:09:59 PDT
Created attachment 339720 [details] Patch for landing.
WebKit Commit Bot
Comment 6 2018-05-07 08:55:02 PDT
Comment on attachment 339720 [details] Patch for landing. Clearing flags on attachment: 339720 Committed r231438: <https://trac.webkit.org/changeset/231438>
Eric Carlson
Comment 7 2018-05-07 14:34:01 PDT
Created attachment 339753 [details] Only log cue text in debug build
Brent Fulgham
Comment 8 2018-05-08 09:53:18 PDT
Comment on attachment 339753 [details] Only log cue text in debug build r=me
WebKit Commit Bot
Comment 9 2018-05-08 10:20:14 PDT
Comment on attachment 339753 [details] Only log cue text in debug build Clearing flags on attachment: 339753 Committed r231490: <https://trac.webkit.org/changeset/231490>
WebKit Commit Bot
Comment 10 2018-05-08 10:20:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.