Bug 185298

Summary: OptionsSet initializer list constructor should be constexpr
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch andersca: review+

Description Antti Koivisto 2018-05-04 06:40:37 PDT
It should.
Comment 1 Antti Koivisto 2018-05-04 06:52:43 PDT
Created attachment 339539 [details]
patch
Comment 2 WebKit Commit Bot 2018-05-04 08:05:40 PDT
Comment on attachment 339539 [details]
patch

Rejecting attachment 339539 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 339539, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/7564449
Comment 3 Antti Koivisto 2018-05-04 08:35:54 PDT
https://trac.webkit.org/r231353
Comment 4 Radar WebKit Bug Importer 2018-05-04 08:36:18 PDT
<rdar://problem/39976940>