Bug 185297

Summary: Improve test at media/modern-media-controls/airplay-button/airplay-button-on.html to not hardcode the -apple-wireless-playback-target-active color
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews205 for win-future none

Antoine Quint
Reported 2018-05-04 04:46:44 PDT
The test at media/modern-media-controls/airplay-button/airplay-button-on.html uses navigator.platform to determine what the RGB color for -apple-wireless-playback-target-active is. We should instead query it from another element using the CSSOM to always get the correct value.
Attachments
Patch (2.15 KB, patch)
2018-05-04 04:49 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews205 for win-future (12.70 MB, application/zip)
2018-05-04 09:43 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2018-05-04 04:46:58 PDT
<rdar://problem/39737716>
Antoine Quint
Comment 2 2018-05-04 04:49:00 PDT
Created attachment 339536 [details] Patch
EWS Watchlist
Comment 3 2018-05-04 09:43:10 PDT
Comment on attachment 339536 [details] Patch Attachment 339536 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7564821 New failing tests: http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
EWS Watchlist
Comment 4 2018-05-04 09:43:21 PDT
Created attachment 339555 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
WebKit Commit Bot
Comment 5 2018-05-04 10:21:27 PDT
Comment on attachment 339536 [details] Patch Clearing flags on attachment: 339536 Committed r231357: <https://trac.webkit.org/changeset/231357>
WebKit Commit Bot
Comment 6 2018-05-04 10:21:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.