Bug 185170

Summary:

Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, bfulgham, cdumez, ddkilzer, ews-watchlist, japhet, pvollan, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Daniel Bates

Reported 2018-05-01 11:49:44 PDT

We should rename CrossOriginPreflightResultCache::empty() to make it clear that it clears out the cache as opposed to testing whether the cache is empty as it is not standard terminology in both WebKit and the C++ Standard Template Library to use the word "empty" in its verb form for a function that clears out a collection. Additional remarks In WebKit a member function named "empty" is expected to return a new instance of the class in the "empty state". One example of this is StringImpl::empty() that returns a new StringImpl that represents the empty string. In the C++ Standard Template Library a member function named "empty" is expected to test its collection to determine if it vacant.

Attachments
Patch (7.36 KB, patch) 2018-05-01 11:56 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.