Bug 185167

Summary: Protect against changes to CoreMedia function signatures
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jer Noble
Reported 2018-05-01 10:42:26 PDT
Protect against changes to CoreMedia function signatures
Attachments
Patch (9.86 KB, patch)
2018-05-01 10:44 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2018-05-01 10:44:10 PDT
<rdar://problem/39806412>
Jer Noble
Comment 2 2018-05-01 10:44:25 PDT
Created attachment 339205 [details] Patch
Eric Carlson
Comment 3 2018-05-01 11:48:39 PDT
Comment on attachment 339205 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339205&action=review > Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp:42 > +#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED <= 120000) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED <= 101400) > +#define CMSAMPLEBUFFERCALL_NOESCAPE > +#else > +#define CMSAMPLEBUFFERCALL_NOESCAPE CF_NOESCAPE > +#endif Why define this here and in the .h file?
Jer Noble
Comment 4 2018-05-01 13:11:23 PDT
(In reply to Eric Carlson from comment #3) > Comment on attachment 339205 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=339205&action=review > > > Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp:42 > > +#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED <= 120000) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED <= 101400) > > +#define CMSAMPLEBUFFERCALL_NOESCAPE > > +#else > > +#define CMSAMPLEBUFFERCALL_NOESCAPE CF_NOESCAPE > > +#endif > > Why define this here and in the .h file? Because the *SoftLink.cpp files never include the *SoftLink.h files.
WebKit Commit Bot
Comment 5 2018-05-01 13:37:37 PDT
Comment on attachment 339205 [details] Patch Clearing flags on attachment: 339205 Committed r231207: <https://trac.webkit.org/changeset/231207>
WebKit Commit Bot
Comment 6 2018-05-01 13:37:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.