Bug 185151

Summary: B3::demoteValues should be able to handle patchpoint terminals
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch saam: review+

Filip Pizlo
Reported 2018-04-30 17:50:22 PDT
Patch forthcoming.
Attachments
the patch (12.14 KB, patch)
2018-04-30 17:59 PDT, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2018-04-30 17:59:58 PDT
Created attachment 339168 [details] the patch
Saam Barati
Comment 2 2018-04-30 18:14:06 PDT
Comment on attachment 339168 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=339168&action=review r=me > Source/JavaScriptCore/b3/B3BreakCriticalEdges.cpp:44 > + // Non-void terminals that are the moral equivalent of jumps trigger critical edge braking > + // because of fixSSA's demoteValues. "of jumps trigger" => "of jumps that trigger" "braking" => "breaking" I would also say instead of "because of fixSSA's demote values" something like "fixSSA's demote values relies on this invariant" > Source/JavaScriptCore/b3/B3FixSSA.cpp:306 > + if (variable) { I think some comment saying this is for terminal patchpoints that are non void might make whoever reads this code in ~6months happier.
Filip Pizlo
Comment 3 2018-05-01 12:56:14 PDT
Landed in https://trac.webkit.org/changeset/231204/webkit
Radar WebKit Bug Importer
Comment 4 2018-05-01 12:57:25 PDT
<rdar://problem/39875383>
Note You need to log in before you can comment on or make changes to this bug.