Bug 185145

Summary:

Introduce WTF::CodePtr and use it to replace MetaAllocatorPtr, MacroAssemblerCodePtr, and FunctionPtr.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, benjamin, calvaris, cdumez, cmarcelo, ews-watchlist, gyuyoung.kim, keith_miller, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
EWS testing.	none
EWS testing.	ews-feeder: commit-queue-
EWS testing.	ews-feeder: commit-queue-
EWS testing.	none

Mark Lam

Reported 2018-04-30 15:09:23 PDT

See https://bugs.webkit.org/show_bug.cgi?id=185110#c2.

Attachments
EWS testing. (355.49 KB, patch) 2022-08-21 20:41 PDT, Mark Lam	no flags	Details Formatted Diff Diff
EWS testing. (355.06 KB, patch) 2022-08-21 20:42 PDT, Mark Lam	ews-feeder: commit-queue-	Details Formatted Diff Diff
EWS testing. (357.58 KB, patch) 2022-08-21 22:46 PDT, Mark Lam	ews-feeder: commit-queue-	Details Formatted Diff Diff
EWS testing. (357.61 KB, patch) 2022-08-21 23:25 PDT, Mark Lam	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2022-08-21 19:59:59 PDT

MetaAllocatorPtr, MacroAssemblerCodePtr, and FunctionPtr all work the same way for the most part: 1. they embed a code pointer. 2. the type of the code pointer has been erased. 3. they provide some utilities for tagging, untagging, and retagging the code pointer. This patch introduces WTF::CodePtr which combines all 3 of these into a single implementation. Also, with FunctionPtr (which previously represent the "untyped" function pointer) now removed, we can renamed TypedFunctionPtr to FunctionPtr. The "untyped" function pointer is now the CodePtr. Also renamed the following method names for conciseness and consistency: 1. executableAddress => taggedPtr 2. untaggedExecutableAddress => untaggedPtr 3. retaggedExecutableAddress => retaggedPtr 4. createFromExecutableAddress => fromTaggedPtr 5. makeFromRawPointer => fromUntaggedPtr

Radar WebKit Bug Importer

Comment 2 2022-08-21 20:00:25 PDT

<rdar://problem/98957747>

Mark Lam

Comment 3 2022-08-21 20:41:23 PDT

Created attachment 461784 [details] EWS testing.

Mark Lam

Comment 4 2022-08-21 20:42:38 PDT

Created attachment 461785 [details] EWS testing.

Mark Lam

Comment 5 2022-08-21 22:46:40 PDT

Created attachment 461789 [details] EWS testing.

Mark Lam

Comment 6 2022-08-21 23:25:46 PDT

Created attachment 461790 [details] EWS testing.

Mark Lam

Comment 7 2022-08-22 09:31:21 PDT

Pull request: https://github.com/WebKit/WebKit/pull/3538

EWS

Comment 8 2022-08-22 19:12:06 PDT

Committed 253667@main (096596f719fb): <https://commits.webkit.org/253667@main> Reviewed commits have been landed. Closing PR #3538 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.