Bug 185141 – [WinCairo] Enable WebKit build by default

• Component: WebKit2
• Status: RESOLVED FIXED

[Basuke Suzuki]

WinCairo is ready to step forward.

[Fujii Hironori]

Created attachment 340685 [details]
Patch

[EWS Watchlist]

Comment on attachment 340685 [details]
Patch

Attachment 340685 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7722067

New failing tests:
http/tests/preload/onload_event.html

[EWS Watchlist]

Created attachment 340698 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Alex Christensen]

Comment on attachment 340685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340685&action=review

> Source/cmake/OptionsWin.cmake:86
> -    if (ENABLE_WIN_CAIRO_WEBKIT)
> -        WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETSCAPE_PLUGIN_API PRIVATE OFF)
> -    endif ()
> +    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETSCAPE_PLUGIN_API PRIVATE OFF)

Is there a reason we want to change this for the AppleWin port?

[Don Olmstead]

(In reply to Alex Christensen from comment #4)
> Comment on attachment 340685 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340685&action=review
> 
> > Source/cmake/OptionsWin.cmake:86
> > -    if (ENABLE_WIN_CAIRO_WEBKIT)
> > -        WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETSCAPE_PLUGIN_API PRIVATE OFF)
> > -    endif ()
> > +    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETSCAPE_PLUGIN_API PRIVATE OFF)
> 
> Is there a reason we want to change this for the AppleWin port?

Its in an if block so it would only affect WinCairo

[Don Olmstead]

Created attachment 340730 [details]
Patch

Use PLATFORM(WIN_CAIRO) instead of USE(CAIRO) to be more specific.

[Don Olmstead]

Comment on attachment 340730 [details]
Patch

Built locally. Think this is good to go now

[Don Olmstead]

Ok so the EWS seems to be failing due to dependencies. This is actually a larger issue with copying headers for building in Tools. Since config.h is shared its going to expect that the file copy happens before it gets there even with TestWTF.

I'll open a separate bug for this particular issue or zero in on one that's already present that causes this.

If this lands and the buildbots go red a clean build should sort it out.

[Fujii Hironori]

Created attachment 340819 [details]
Patch

* Fix dependency issue of WebKitTestAPI

[Per Arne Vollan]

Comment on attachment 340819 [details]
Patch

R=me.

[WebKit Commit Bot]

Comment on attachment 340819 [details]
Patch

Clearing flags on attachment: 340819

Committed r232038: <https://trac.webkit.org/changeset/232038>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40435722>