Bug 185117

Summary: Fixed a very unlikely race condition in WTF::WordLock
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, clucier, cmarcelo, dbates, ews-watchlist, fpizlo, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Geoffrey Garen
Reported 2018-04-28 21:19:49 PDT
Fixed a very unlikely race condition in WTF::WordLock
Attachments
Patch (3.14 KB, patch)
2018-04-28 21:34 PDT, Geoffrey Garen 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2018-04-28 21:34:07 PDT
Created attachment 339088 [details] Patch
Geoffrey Garen
Comment 2 2018-04-28 21:36:08 PDT
I'm not sure which arguments are best for LockSpeedTest. These results looked OK to me: ~/OpenSource> ./LockSpeedTest-baseline wordlock 1 4 10 20 40 2 WTFWordLock: 15528.899 KHz WTFWordLock = {15528.899}; ===== ~/OpenSource> ./LockSpeedTest wordlock 1 4 10 20 40 2 WTFWordLock: 15297.111 KHz WTFWordLock = {15297.111}; ~/OpenSource> ./LockSpeedTest-baseline wordlock 1 4 128 1024 40 2 WTFWordLock: 1505.704 KHz WTFWordLock = {1505.704}; ===== ~/OpenSource> ./LockSpeedTest wordlock 1 4 128 1024 40 2 WTFWordLock: 1499.678 KHz WTFWordLock = {1499.678};
Geoffrey Garen
Comment 3 2018-04-28 21:42:51 PDT
Side note: ParkingLot does not have this bug. (It uses reference counting instead of the "lock more" solution I used here.)
Geoffrey Garen
Comment 4 2018-04-29 08:23:54 PDT
Committed r231148: <https://trac.webkit.org/changeset/231148>
Radar WebKit Bug Importer
Comment 5 2018-04-29 08:24:18 PDT
<rdar://problem/39824505>
Yusuke Suzuki
Comment 6 2022-04-06 03:33:01 PDT
*** Bug 185547 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.