Bug 185101

Summary:

Move StructureIsImmortal to out of line flags.

Product:

WebKit

Reporter:

Keith Miller <keith_miller>

Component:

New Bugs

Assignee:

Keith Miller <keith_miller>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, mark.lam, msaboff, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews114 for mac-sierra	none
Patch	none
Patch	none
Patch	none
Patch for landing	none
Patch for landing	none

Keith Miller

Reported 2018-04-27 18:19:41 PDT

Move StructureIsImmortal to out of line flags.

Attachments
Patch (6.03 KB, patch) 2018-04-27 18:25 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews114 for mac-sierra (1.04 MB, application/zip) 2018-04-27 19:43 PDT, EWS Watchlist	no flags	Details
Patch (6.94 KB, patch) 2018-04-30 12:51 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch (6.94 KB, patch) 2018-04-30 12:58 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch (7.13 KB, patch) 2018-04-30 13:10 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch for landing (7.13 KB, patch) 2018-04-30 13:11 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch for landing (7.12 KB, patch) 2018-04-30 13:12 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Keith Miller

Comment 1 2018-04-27 18:25:56 PDT

Created attachment 339046 [details] Patch

EWS Watchlist

Comment 2 2018-04-27 19:43:20 PDT

Comment on attachment 339046 [details] Patch Attachment 339046 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7486888 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 3 2018-04-27 19:43:21 PDT

Created attachment 339052 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6

Saam Barati

Comment 4 2018-04-27 19:50:13 PDT

Bots seem unhappy.

Saam Barati

Comment 5 2018-04-27 19:50:41 PDT

Comment on attachment 339046 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339046&action=review > Source/JavaScriptCore/runtime/JSTypeInfo.h:45 > static const unsigned OverridesToThis = 1 << 6; // If this is false then this returns something other than 'this'. Non-object cells that are visible to JS have this set as do some exotic objects. > static const unsigned HasStaticPropertyTable = 1 << 7; Let's slide these other ones down?

Keith Miller

Comment 6 2018-04-30 12:51:38 PDT

Created attachment 339137 [details] Patch

Keith Miller

Comment 7 2018-04-30 12:58:45 PDT

Created attachment 339139 [details] Patch

Saam Barati

Comment 8 2018-04-30 13:07:12 PDT

Comment on attachment 339139 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339139&action=review > Source/JavaScriptCore/runtime/JSTypeInfo.h:45 > static const unsigned OverridesToThis = 1 << 6; // If this is false then this returns something other than 'this'. Non-object cells that are visible to JS have this set as do some exotic objects. > static const unsigned HasStaticPropertyTable = 1 << 7; Why not slide these down?

Keith Miller

Comment 9 2018-04-30 13:08:38 PDT

Comment on attachment 339139 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339139&action=review >> Source/JavaScriptCore/runtime/JSTypeInfo.h:45 >> static const unsigned HasStaticPropertyTable = 1 << 7; > > Why not slide these down? Whoops, I meant to do that but I touched the wrong checkout... Will fix before landing.

Keith Miller

Comment 10 2018-04-30 13:10:54 PDT

Created attachment 339140 [details] Patch

Keith Miller

Comment 11 2018-04-30 13:11:39 PDT

Created attachment 339141 [details] Patch for landing

Keith Miller

Comment 12 2018-04-30 13:12:02 PDT

Created attachment 339142 [details] Patch for landing

Keith Miller

Comment 13 2018-04-30 13:22:14 PDT

Committed r231166: <https://trac.webkit.org/changeset/231166>

Radar WebKit Bug Importer

Comment 14 2018-04-30 13:23:19 PDT

<rdar://problem/39846246>

Note You need to log in before you can comment on or make changes to this bug.