Summary: | Refactor filter list checking code | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
Component: | Compositing | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
Status: | REOPENED --- | ||||||||||||
Severity: | Normal | CC: | ews-watchlist, fred.wang, mmaxfield, simon.fraser, tonikitoo, webkit-bug-importer, ysuzuki, zalan | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2018-04-27 13:33:49 PDT
Created attachment 339018 [details]
Patch
Comment on attachment 339018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339018&action=review > Source/WebCore/animation/KeyframeEffectReadOnly.h:153 > + bool checkForMatchingFilterFunctionLists(CSSPropertyID, const std::function<const FilterOperations& (const RenderStyle&)>&) const; @smfr: I think we should really forward-declare FilterOperations here. Sure. Created attachment 349173 [details] Follow-up fix of possible build failure (In reply to Simon Fraser (smfr) from comment #5) > Sure. For the record, I'm found this after getting a build failure with a patch for bug 188043 ; probably because of the unified build thing. smfr: review ping? Committed r235847: <https://trac.webkit.org/changeset/235847> (In reply to Simon Fraser (smfr) from comment #2) > https://trac.webkit.org/changeset/231112/webkit Mmh, that commit adds one more change with respect to the patch in Source/WebCore/page/animation/KeyframeAnimation.h that requires similar fixup. Created attachment 349392 [details]
Another follow-up fix of potential build failure
Comment on attachment 349392 [details]
Another follow-up fix of potential build failure
rs=me
Committed r235894: <https://trac.webkit.org/changeset/235894> Reopening to attach new patch. Created attachment 349552 [details]
Patch
Comment on attachment 349552 [details]
Patch
We often inline functions for performance, and fonts are used pretty often. Is this a performance regression?
r=me if this isn’t a performance regression Comment on attachment 349552 [details]
Patch
Mmh, wrong bug sorry...
|