Bug 185085

Summary: AX: Accessibility needs to know which part of the content view is visible on iOS
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch none

Nan Wang
Reported 2018-04-27 13:06:10 PDT
We should expose the unobscuredContentRect() on iOS accessibility.
Attachments
patch (6.98 KB, patch)
2018-04-27 13:18 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (7.67 KB, patch)
2018-04-27 13:58 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-04-27 13:06:34 PDT
<rdar://problem/39801363>
Nan Wang
Comment 2 2018-04-27 13:18:42 PDT
Created attachment 339017 [details] patch
chris fleizach
Comment 3 2018-04-27 13:24:36 PDT
Comment on attachment 339017 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=339017&action=review > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1676 > + return CGRectZero; Does this account for objects in an iframe and various states of scroll offset and embedded iframes
Nan Wang
Comment 4 2018-04-27 13:31:30 PDT
(In reply to chris fleizach from comment #3) > Comment on attachment 339017 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=339017&action=review > > > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1676 > > + return CGRectZero; > > Does this account for objects in an iframe and various states of scroll > offset and embedded iframes I think so, this is per frameview.
chris fleizach
Comment 5 2018-04-27 13:32:38 PDT
Ok probably good to test that
Nan Wang
Comment 6 2018-04-27 13:58:06 PDT
Created attachment 339021 [details] patch added iframe test case
WebKit Commit Bot
Comment 7 2018-04-27 14:58:39 PDT
Comment on attachment 339021 [details] patch Clearing flags on attachment: 339021 Committed r231113: <https://trac.webkit.org/changeset/231113>
WebKit Commit Bot
Comment 8 2018-04-27 14:58:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.