Bug 185082

Summary: Shutdown WindowServer connections after checking in with launch services
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebCore Misc.Assignee: Per Arne Vollan <pvollan>
Status: NEW ---    
Severity: Normal CC: bfulgham, commit-queue, ews-watchlist, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+
Patch
none
Archive of layout-test-results from ews206 for win-future none

Description Per Arne Vollan 2018-04-27 10:30:48 PDT 
When WindowServer access is blocked in the WebContent process, we should shutdown all connections after checking in with launch services.
Comment 1 Per Arne Vollan 2018-04-27 10:31:58 PDT 
<rdar://problem/39613173>
Comment 2 Per Arne Vollan 2018-04-27 10:37:15 PDT 
Created attachment 339001 [details]
Patch
Comment 3 Per Arne Vollan 2018-04-27 10:38:23 PDT 
Created attachment 339002 [details]
Patch
Comment 4 Brent Fulgham 2018-04-27 15:44:44 PDT 
Comment on attachment 339002 [details]
Patch

Looks great! r=me.
Comment 5 Per Arne Vollan 2018-05-04 14:02:34 PDT 
Created attachment 339592 [details]
Patch
Comment 6 Brent Fulgham 2018-05-04 15:20:53 PDT 
Comment on attachment 339592 [details]
Patch

r=me if the EWS bots are happy.
Comment 7 EWS Watchlist 2018-05-04 16:12:46 PDT 
Comment on attachment 339592 [details]
Patch

Attachment 339592 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7569434

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
Comment 8 EWS Watchlist 2018-05-04 16:12:57 PDT 
Created attachment 339605 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 9 Per Arne Vollan 2018-05-04 16:16:32 PDT 
Comment on attachment 339592 [details]
Patch

Thanks for reviewing!
Comment 10 Brent Fulgham 2018-05-04 16:21:12 PDT 
Per Arne: Did you see this test failure:

http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html

Is that related to this change?
Comment 11 Per Arne Vollan 2018-05-04 16:23:06 PDT 
(In reply to Brent Fulgham from comment #10)
> Per Arne: Did you see this test failure:
> 
> http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.
> html
> 
> Is that related to this change?

I believe this is a flaky failure from the Windows bots.
Comment 12 WebKit Commit Bot 2018-05-04 16:42:49 PDT 
Comment on attachment 339592 [details]
Patch

Clearing flags on attachment: 339592

Committed r231389: <https://trac.webkit.org/changeset/231389>