Summary: | compilation error while building with gcc < 4.x compilers on latest nightlies | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Srinivas Rao M Hamse <msrinirao> | ||||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | ||||||||||||
Priority: | P3 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | Linux | ||||||||||||
Attachments: |
|
Description
Srinivas Rao M Hamse
2008-04-14 23:20:16 PDT
Created attachment 20545 [details]
Suggested patch for this bug
Attaching the patch for this bug. I am not sure whether it affects any other module. Please review it.
Comment on attachment 20545 [details]
Suggested patch for this bug
Although darin's comment was kinda confusing on the list, the proper behavior is to mark the patch review=? instead of review=+
This patch requires a ChangeLog (see prepare-ChangeLog) before we can land it. Thanks!
Created attachment 20546 [details]
latest patch
Patch created using svn-createpatch on 31896
Prepared a Changelog entry
Created attachment 20577 [details]
better patch
This patch contains no ifdefs to check the compiler. But the line with typedef is made public in order for the compilation with GCC 3.x go through. Done after discussing with Eric Seidel and Maciej Stachowiak on IRC
Created attachment 20612 [details]
corrected patch
Added the Changelog comment
Comment on attachment 20612 [details]
corrected patch
r=me
|