Bug 185050

Summary:

[Extra zoom mode] Add a mechanism to override default viewport behaviors in extra zoom mode

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebKit Misc.

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, bdakin, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, simon.fraser, thorton, timothy

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Part 1	thorton: review+
Part 1 v2 (try to fix GTK/WPE)	none
Part 2	thorton: review+
Part 3	thorton: review+
Part 1 (patch for landing)	none
Part 2 (patch for landing)	none
Part 3 (patch for landing)	none

Wenson Hsieh

Reported 2018-04-26 14:42:53 PDT

<rdar://problem/39624038>

Attachments
Part 1 (64.42 KB, patch) 2018-04-26 19:42 PDT, Wenson Hsieh	thorton: review+	Details Formatted Diff Diff
Part 1 v2 (try to fix GTK/WPE) (64.55 KB, patch) 2018-04-26 21:01 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Part 2 (58.71 KB, patch) 2018-04-26 21:37 PDT, Wenson Hsieh	thorton: review+	Details Formatted Diff Diff
Part 3 (5.93 KB, patch) 2018-04-26 22:53 PDT, Wenson Hsieh	thorton: review+	Details Formatted Diff Diff
Part 1 (patch for landing) (64.50 KB, patch) 2018-04-27 07:51 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Part 2 (patch for landing) (58.75 KB, patch) 2018-04-27 08:40 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Part 3 (patch for landing) (5.87 KB, patch) 2018-04-27 09:10 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2018-04-26 19:42:44 PDT

Created attachment 338953 [details] Part 1

Tim Horton

Comment 2 2018-04-26 20:31:01 PDT

Comment on attachment 338953 [details] Part 1 View in context: https://bugs.webkit.org/attachment.cgi?id=338953&action=review > Source/WebKit/UIProcess/ios/WKContentView.mm:-405 > - _webView._forceHorizontalViewportShrinkToFit, Nice! It is too rare that one of these parameters is red instead of green :) > Tools/ChangeLog:9 > + Remove an test that's no longer useful, now that the SPI it was testing is gone. This functionality is now an test!

Wenson Hsieh

Comment 3 2018-04-26 21:01:13 PDT

Created attachment 338962 [details] Part 1 v2 (try to fix GTK/WPE)

Wenson Hsieh

Comment 4 2018-04-26 21:37:31 PDT

Created attachment 338964 [details] Part 2

Wenson Hsieh

Comment 5 2018-04-26 22:53:16 PDT

Created attachment 338975 [details] Part 3

Wenson Hsieh

Comment 6 2018-04-27 07:51:44 PDT

Created attachment 338987 [details] Part 1 (patch for landing)

WebKit Commit Bot

Comment 7 2018-04-27 08:35:55 PDT

Comment on attachment 338987 [details] Part 1 (patch for landing) Clearing flags on attachment: 338987 Committed r231095: <https://trac.webkit.org/changeset/231095>

Wenson Hsieh

Comment 8 2018-04-27 08:40:17 PDT

Created attachment 338992 [details] Part 2 (patch for landing)

WebKit Commit Bot

Comment 9 2018-04-27 09:07:24 PDT

Comment on attachment 338992 [details] Part 2 (patch for landing) Clearing flags on attachment: 338992 Committed r231097: <https://trac.webkit.org/changeset/231097>

Wenson Hsieh

Comment 10 2018-04-27 09:10:36 PDT

Created attachment 338994 [details] Part 3 (patch for landing)

WebKit Commit Bot

Comment 11 2018-04-27 11:03:20 PDT

Comment on attachment 338994 [details] Part 3 (patch for landing) Clearing flags on attachment: 338994 Committed r231106: <https://trac.webkit.org/changeset/231106>

Note You need to log in before you can comment on or make changes to this bug.