Bug 185047

Summary:

Implement rendering support for the color-filter CSS property

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, rniwa, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews103 for mac-sierra	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Archive of layout-test-results from ews117 for mac-sierra	none
Patch	none

Simon Fraser (smfr)

Reported 2018-04-26 14:20:19 PDT

Implement rendering support for the color-filter CSS property

Attachments
Patch (150.30 KB, patch) 2018-04-26 14:27 PDT, Simon Fraser (smfr)	thorton: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.59 MB, application/zip) 2018-04-26 15:32 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews103 for mac-sierra (2.89 MB, application/zip) 2018-04-26 15:41 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.61 MB, application/zip) 2018-04-26 16:12 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-sierra (3.35 MB, application/zip) 2018-04-26 16:16 PDT, EWS Watchlist	no flags	Details
Patch (154.80 KB, patch) 2018-04-26 16:18 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2018-04-26 14:27:20 PDT

Created attachment 338913 [details] Patch

EWS Watchlist

Comment 2 2018-04-26 15:32:04 PDT

Comment on attachment 338913 [details] Patch Attachment 338913 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7473063 New failing tests: css3/color-filters/color-filter-filter-list.html css3/color-filters/color-filter-hue-rotate.html css3/color-filters/color-filter-sepia.html css3/color-filters/color-filter-grayscale.html css3/color-filters/color-filter-saturate.html

EWS Watchlist

Comment 3 2018-04-26 15:32:05 PDT

Created attachment 338928 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 2018-04-26 15:41:36 PDT

Comment on attachment 338913 [details] Patch Attachment 338913 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7473144 New failing tests: css3/color-filters/color-filter-box-shadow.html css3/color-filters/color-filter-grayscale.html css3/color-filters/color-filter-sepia.html css3/color-filters/color-filter-outline.html css3/color-filters/color-filter-current-color.html css3/color-filters/color-filter-inherits.html css3/color-filters/color-filter-saturate.html css3/color-filters/color-filter-color-property-list-item.html css3/color-filters/color-filter-column-rule.html css3/color-filters/color-filter-text-emphasis.html css3/color-filters/color-filter-hue-rotate.html css3/color-filters/color-filter-color-text-decorations.html css3/color-filters/color-filter-backgrounds-borders.html css3/color-filters/color-filter-filter-list.html css3/color-filters/color-filter-color-property.html

EWS Watchlist

Comment 5 2018-04-26 15:41:37 PDT

Created attachment 338930 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-04-26 16:11:59 PDT

Comment on attachment 338913 [details] Patch Attachment 338913 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7473282 New failing tests: css3/color-filters/color-filter-filter-list.html css3/color-filters/color-filter-hue-rotate.html css3/color-filters/color-filter-sepia.html css3/color-filters/color-filter-grayscale.html css3/color-filters/color-filter-saturate.html

EWS Watchlist

Comment 7 2018-04-26 16:12:00 PDT

Created attachment 338933 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

EWS Watchlist

Comment 8 2018-04-26 16:16:10 PDT

Comment on attachment 338913 [details] Patch Attachment 338913 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7473236 New failing tests: css3/color-filters/color-filter-box-shadow.html css3/color-filters/color-filter-outline.html css3/color-filters/color-filter-current-color.html css3/color-filters/color-filter-inherits.html css3/color-filters/color-filter-color-property-list-item.html css3/color-filters/color-filter-column-rule.html css3/color-filters/color-filter-text-emphasis.html css3/color-filters/color-filter-color-text-decorations.html css3/color-filters/color-filter-backgrounds-borders.html css3/color-filters/color-filter-color-property.html

EWS Watchlist

Comment 9 2018-04-26 16:16:11 PDT

Created attachment 338934 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6

Simon Fraser (smfr)

Comment 10 2018-04-26 16:18:12 PDT

Created attachment 338936 [details] Patch

EWS Watchlist

Comment 11 2018-04-26 16:21:37 PDT

Attachment 338936 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ColorUtilities.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 87 files If any of these errors are false positives, please file a bug against check-webkit-style.

Simon Fraser (smfr)

Comment 12 2018-04-26 17:13:12 PDT

rdar://problem/39664967

Simon Fraser (smfr)

Comment 13 2018-04-26 17:13:42 PDT

https://trac.webkit.org/changeset/231082/

Note You need to log in before you can comment on or make changes to this bug.