Bug 185021

Summary:

CORS preflight checker should add a console message when preflight load is blocked

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, commit-queue, dbates, ews-watchlist, japhet, mkwst, rniwa, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews102 for mac-sierra	none
Patch	none
Patch	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews116 for mac-sierra	none
Archive of layout-test-results from ews200 for win-future	none
Patch	none
Patch	none

youenn fablet

Reported 2018-04-25 18:16:46 PDT

preflight checker should add a console message when preflight load is blocked

Attachments
Patch (6.58 KB, patch) 2018-04-25 18:18 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (7.42 KB, patch) 2018-04-25 18:21 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (7.59 KB, patch) 2018-04-25 18:30 PDT, youenn fablet	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.25 MB, application/zip) 2018-04-25 19:34 PDT, EWS Watchlist	no flags	Details
Patch (13.56 KB, patch) 2018-04-25 19:53 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (14.58 KB, patch) 2018-04-25 21:38 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.29 MB, application/zip) 2018-04-25 22:42 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews116 for mac-sierra (3.04 MB, application/zip) 2018-04-25 23:11 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews200 for win-future (12.66 MB, application/zip) 2018-04-26 08:44 PDT, EWS Watchlist	no flags	Details
Patch (15.70 KB, patch) 2018-04-26 08:55 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (20.45 KB, patch) 2018-04-26 09:57 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2018-04-25 18:18:11 PDT

Created attachment 338841 [details] Patch

youenn fablet

Comment 2 2018-04-25 18:21:04 PDT

Created attachment 338842 [details] Patch

youenn fablet

Comment 3 2018-04-25 18:30:32 PDT

Created attachment 338844 [details] Patch

EWS Watchlist

Comment 4 2018-04-25 19:34:18 PDT

Comment on attachment 338844 [details] Patch Attachment 338844 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7463193 New failing tests: imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred.htm imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-basic-setrequestheader.htm imported/w3c/web-platform-tests/cors/late-upload-events.htm imported/w3c/web-platform-tests/cors/request-headers.htm

EWS Watchlist

Comment 5 2018-04-25 19:34:19 PDT

Created attachment 338849 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

youenn fablet

Comment 6 2018-04-25 19:53:07 PDT

Created attachment 338851 [details] Patch

Sam Weinig

Comment 7 2018-04-25 21:03:03 PDT

Comment on attachment 338851 [details] Patch These errors would be more helpful if they included what resource / URL the preflight was for. I am also not sure just saying "Preflight" in the error is very clear that this is referring to a CORS preflight.

youenn fablet

Comment 8 2018-04-25 21:11:16 PDT

(In reply to Sam Weinig from comment #7) > Comment on attachment 338851 [details] > Patch > > These errors would be more helpful if they included what resource / URL the > preflight was for. I am also not sure just saying "Preflight" in the error > is very clear that this is referring to a CORS preflight. I will make the message clearer about the meaning of preflight. As of whether printing the URL or not, the message just after the "preflight blocked" prints the URL. It would be somehow useful to print the preflight request URL in the case of redirections if the second message was displaying the original URL. I am not sure that we are very consistent on that regard currently.

youenn fablet

Comment 9 2018-04-25 21:38:05 PDT

Created attachment 338853 [details] Patch

EWS Watchlist

Comment 10 2018-04-25 22:42:20 PDT

Comment on attachment 338853 [details] Patch Attachment 338853 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7464494 New failing tests: imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred.htm imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-basic-setrequestheader.htm imported/w3c/web-platform-tests/cors/request-headers.htm

EWS Watchlist

Comment 11 2018-04-25 22:42:21 PDT

Created attachment 338857 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 12 2018-04-25 23:11:24 PDT

Comment on attachment 338853 [details] Patch Attachment 338853 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7464505 New failing tests: imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred.htm imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-basic-setrequestheader.htm imported/w3c/web-platform-tests/cors/request-headers.htm

EWS Watchlist

Comment 13 2018-04-25 23:11:25 PDT

Created attachment 338860 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 14 2018-04-26 08:43:53 PDT

Comment on attachment 338853 [details] Patch Attachment 338853 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7467805 New failing tests: http/tests/preload/onload_event.html

EWS Watchlist

Comment 15 2018-04-26 08:44:05 PDT

Created attachment 338873 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

youenn fablet

Comment 16 2018-04-26 08:55:43 PDT

Created attachment 338875 [details] Patch

youenn fablet

Comment 17 2018-04-26 09:57:05 PDT

Created attachment 338882 [details] Patch

WebKit Commit Bot

Comment 18 2018-04-26 11:18:00 PDT

Comment on attachment 338882 [details] Patch Clearing flags on attachment: 338882 Committed r231056: <https://trac.webkit.org/changeset/231056>

WebKit Commit Bot

Comment 19 2018-04-26 11:18:02 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 20 2018-04-26 11:20:23 PDT

<rdar://problem/39764121>

Note You need to log in before you can comment on or make changes to this bug.