Bug 185015

Summary: Use unified build for WebProcess
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ews-watchlist, ggaren, keith_miller, realdawei, rniwa, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 188868    
Bug Blocks: 185010    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews104 for mac-sierra-wk2
none
Patch
none
Patch none

Michael Catanzaro
Reported 2018-04-25 16:53:11 PDT
Use unified build for WebProcess
Attachments
Patch (326.30 KB, patch)
2018-08-21 00:36 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (328.92 KB, patch)
2018-08-21 10:37 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (330.48 KB, patch)
2018-08-21 11:12 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (331.97 KB, patch)
2018-08-21 11:26 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (332.08 KB, patch)
2018-08-21 11:30 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (331.90 KB, patch)
2018-08-21 11:58 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.82 MB, application/zip)
2018-08-21 13:37 PDT, EWS Watchlist 		no flags
Details
Patch (329.18 KB, patch)
2018-08-21 16:30 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (332.24 KB, patch)
2018-08-21 19:23 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-08-21 00:36:54 PDT
Created attachment 347619 [details] Patch
Tim Horton
Comment 2 2018-08-21 00:37:20 PDT
I haven't gotten it to build all the way through yet, but it's a start.
Tim Horton
Comment 3 2018-08-21 10:37:58 PDT
Created attachment 347657 [details] Patch
Tim Horton
Comment 4 2018-08-21 11:12:24 PDT
Created attachment 347660 [details] Patch
Tim Horton
Comment 5 2018-08-21 11:26:27 PDT
Created attachment 347661 [details] Patch
Tim Horton
Comment 6 2018-08-21 11:30:17 PDT
Created attachment 347662 [details] Patch
Tim Horton
Comment 7 2018-08-21 11:58:17 PDT
Created attachment 347669 [details] Patch
EWS Watchlist
Comment 8 2018-08-21 13:37:16 PDT
Comment on attachment 347669 [details] Patch Attachment 347669 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8933671 New failing tests: tiled-drawing/scrolling/non-fast-region/wheel-event-plugin.html
EWS Watchlist
Comment 9 2018-08-21 13:37:18 PDT
Created attachment 347683 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Tim Horton
Comment 10 2018-08-21 16:30:59 PDT
Created attachment 347723 [details] Patch
Tim Horton
Comment 11 2018-08-21 19:23:29 PDT
Created attachment 347753 [details] Patch
WebKit Commit Bot
Comment 12 2018-08-22 09:54:25 PDT
Comment on attachment 347753 [details] Patch Clearing flags on attachment: 347753 Committed r235176: <https://trac.webkit.org/changeset/235176>
WebKit Commit Bot
Comment 13 2018-08-22 09:54:27 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 14 2018-08-22 09:55:46 PDT
<rdar://problem/43609045>
Dawei Fenton (:realdawei)
Comment 15 2018-08-22 15:34:09 PDT
(In reply to WebKit Commit Bot from comment #12) > Comment on attachment 347753 [details] > Patch > > Clearing flags on attachment: 347753 > > Committed r235176: <https://trac.webkit.org/changeset/235176> This is breaking internal builds, rolling out.
Tim Horton
Comment 16 2018-08-22 15:39:26 PDT
(In reply to David Fenton (:realdawei) from comment #15) > (In reply to WebKit Commit Bot from comment #12) > > Comment on attachment 347753 [details] > > Patch > > > > Clearing flags on attachment: 347753 > > > > Committed r235176: <https://trac.webkit.org/changeset/235176> > > This is breaking internal builds, rolling out. Please wait for https://bugs.webkit.org/show_bug.cgi?id=188865?
Dawei Fenton (:realdawei)
Comment 17 2018-08-22 15:39:36 PDT
Reverted r235176 for reason: broke internal builds Committed r235204: <https://trac.webkit.org/changeset/235204>
Dawei Fenton (:realdawei)
Comment 18 2018-08-22 15:44:57 PDT
Reverted r235204 for reason: reverting previous rollout Committed r235205: <https://trac.webkit.org/changeset/235205>
Note You need to log in before you can comment on or make changes to this bug.