Bug 185014

Summary:

Use unified build for UIProcess

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

WebKit2

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, ews-watchlist, ggaren, mcatanzaro, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

185010

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Michael Catanzaro

Reported 2018-04-25 16:52:51 PDT

Use unified build for UIProcess

Attachments
Patch (414.16 KB, patch) 2018-08-23 14:57 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (409.56 KB, patch) 2018-08-23 15:16 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (412.05 KB, patch) 2018-08-23 15:24 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (412.98 KB, patch) 2018-08-23 17:20 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2018-08-23 14:57:00 PDT

Created attachment 347957 [details] Patch

EWS Watchlist

Comment 2 2018-08-23 15:00:27 PDT

Attachment 347957 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/mac/WKImmediateActionController.mm:404: 'page' is incorrectly named. It should be named 'protector' or 'protected_page'. [readability/naming/protected] [4] ERROR: Source/WebKit/UIProcess/mac/WKImmediateActionController.mm:440: 'page' is incorrectly named. It should be named 'protector' or 'protected_page'. [readability/naming/protected] [4] Total errors found: 2 in 110 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 3 2018-08-23 15:16:14 PDT

Created attachment 347961 [details] Patch

EWS Watchlist

Comment 4 2018-08-23 15:19:20 PDT

Attachment 347961 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/mac/WKImmediateActionController.mm:404: 'page' is incorrectly named. It should be named 'protector' or 'protected_page'. [readability/naming/protected] [4] ERROR: Source/WebKit/UIProcess/mac/WKImmediateActionController.mm:440: 'page' is incorrectly named. It should be named 'protector' or 'protected_page'. [readability/naming/protected] [4] Total errors found: 2 in 110 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 5 2018-08-23 15:24:51 PDT

Created attachment 347962 [details] Patch

EWS Watchlist

Comment 6 2018-08-23 15:27:20 PDT

Attachment 347962 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/mac/WKImmediateActionController.mm:404: 'page' is incorrectly named. It should be named 'protector' or 'protected_page'. [readability/naming/protected] [4] ERROR: Source/WebKit/UIProcess/mac/WKImmediateActionController.mm:440: 'page' is incorrectly named. It should be named 'protector' or 'protected_page'. [readability/naming/protected] [4] Total errors found: 2 in 111 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 7 2018-08-23 17:00:02 PDT

Comment on attachment 347962 [details] Patch Rejecting attachment 347962 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 347962, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: file Source/WebKit/UIProcess/VisitedLinkStore.cpp patching file Source/WebKit/UIProcess/WKInspectorHighlightView.mm patching file Source/WebKit/UIProcess/WebBackForwardList.cpp patching file Source/WebKit/UIProcess/WebContextMenuListenerProxy.cpp patching file Source/WebKit/UIProcess/WebCookieManagerProxy.cpp patching file Source/WebKit/UIProcess/WebEditCommandProxy.cpp patching file Source/WebKit/UIProcess/WebFrameProxy.cpp patching file Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp patching file Source/WebKit/UIProcess/WebInspectorProxy.cpp patching file Source/WebKit/UIProcess/WebNavigationState.cpp patching file Source/WebKit/UIProcess/WebOpenPanelResultListenerProxy.cpp patching file Source/WebKit/UIProcess/WebPageInjectedBundleClient.cpp patching file Source/WebKit/UIProcess/WebPageProxy.cpp patching file Source/WebKit/UIProcess/WebProcessPool.cpp patching file Source/WebKit/UIProcess/WebProcessProxy.cpp patching file Source/WebKit/UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp patching file Source/WebKit/UIProcess/WebURLSchemeHandler.cpp patching file Source/WebKit/UIProcess/WebURLSchemeTask.cpp patching file Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp patching file Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreX11.cpp patching file Source/WebKit/UIProcess/ios/DragDropInteractionState.mm patching file Source/WebKit/UIProcess/ios/InputViewUpdateDeferrer.mm patching file Source/WebKit/UIProcess/ios/PageClientImplIOS.mm patching file Source/WebKit/UIProcess/ios/SmartMagnificationController.mm patching file Source/WebKit/UIProcess/ios/TextCheckerIOS.mm patching file Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm patching file Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm patching file Source/WebKit/UIProcess/ios/WKApplicationStateTrackingView.mm patching file Source/WebKit/UIProcess/ios/WKGeolocationProviderIOS.mm patching file Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm patching file Source/WebKit/UIProcess/ios/WKLegacyPDFView.mm patching file Source/WebKit/UIProcess/ios/WKPDFView.mm patching file Source/WebKit/UIProcess/ios/WKScrollView.mm patching file Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm patching file Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm patching file Source/WebKit/UIProcess/mac/CorrectionPanel.mm patching file Source/WebKit/UIProcess/mac/PageClientImplMac.mm patching file Source/WebKit/UIProcess/mac/RemoteWebInspectorProxyMac.mm patching file Source/WebKit/UIProcess/mac/TextCheckerMac.mm patching file Source/WebKit/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm patching file Source/WebKit/UIProcess/mac/ViewGestureControllerMac.mm patching file Source/WebKit/UIProcess/mac/ViewSnapshotStore.mm patching file Source/WebKit/UIProcess/mac/WKFullKeyboardAccessWatcher.mm patching file Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm patching file Source/WebKit/UIProcess/mac/WKImmediateActionController.mm patching file Source/WebKit/UIProcess/mac/WKInspectorViewController.mm patching file Source/WebKit/UIProcess/mac/WKPrintingView.mm patching file Source/WebKit/UIProcess/mac/WKTextFinderClient.mm patching file Source/WebKit/UIProcess/mac/WKTextInputWindowController.mm patching file Source/WebKit/UIProcess/mac/WKViewLayoutStrategy.mm patching file Source/WebKit/UIProcess/mac/WebColorPickerMac.mm patching file Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm patching file Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm patching file Source/WebKit/UIProcess/mac/WebPageProxyMac.mm patching file Source/WebKit/UIProcess/mac/WebPopupMenuProxyMac.mm patching file Source/WebKit/UIProcess/win/PageClientImpl.cpp patching file Source/WebKit/UIProcess/win/TextCheckerWin.cpp patching file Source/WebKit/UIProcess/win/WebContextMenuProxyWin.cpp patching file Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp patching file Source/WebKit/UIProcess/win/WebView.cpp patching file Source/WebKit/UIProcess/wpe/TextCheckerWPE.cpp patching file Source/WebKit/UIProcess/wpe/WebPasteboardProxyWPE.cpp patching file Source/WebKit/WebKit.xcodeproj/project.pbxproj Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 973aa89455c..d7cb7b5eed1 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 235257 = 973aa89455c79e2e8f42fc9694c50f2b1fa29151 r235258 = 1e8ac4869b84e040b52f333d13b10143fc946ccc r235259 = 5afc1d04cc556af31b74618b3d04255e6db777d3 r235260 = 69e00bb40762e37185478f0000bf7845147eb20c r235261 = ebc7eff21c81f858a2254cec49419e7a0783dc43 r235262 = d7cb7b5eed19afb44d76d1b02f74f937a3ac7ec8 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/8965187

Tim Horton

Comment 8 2018-08-23 17:20:07 PDT

Created attachment 347978 [details] Patch

EWS Watchlist

Comment 9 2018-08-23 17:22:29 PDT

Attachment 347978 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/mac/WKImmediateActionController.mm:404: 'page' is incorrectly named. It should be named 'protector' or 'protected_page'. [readability/naming/protected] [4] ERROR: Source/WebKit/UIProcess/mac/WKImmediateActionController.mm:440: 'page' is incorrectly named. It should be named 'protector' or 'protected_page'. [readability/naming/protected] [4] Total errors found: 2 in 111 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 10 2018-08-23 17:59:21 PDT

Comment on attachment 347978 [details] Patch Clearing flags on attachment: 347978 Committed r235265: <https://trac.webkit.org/changeset/235265>

WebKit Commit Bot

Comment 11 2018-08-23 17:59:23 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 12 2018-08-23 18:00:37 PDT

<rdar://problem/43667139>

Note You need to log in before you can comment on or make changes to this bug.