Summary: | Use unified build for NetworkProcess | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||||
Component: | WebKit2 | Assignee: | Michael Catanzaro <mcatanzaro> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, bugs-noreply, calvaris, cdumez, cgarcia, commit-queue, eric.carlson, ews-watchlist, keith_miller, mcatanzaro, thorton, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 185010 | ||||||||
Attachments: |
|
Description
Michael Catanzaro
2018-04-25 16:51:00 PDT
(Note I'm only touching cross-platform files here.) Created attachment 338830 [details]
Patch
Anyone interested in helping with the XCode portion of this? Ping reviewers. Let's land CMake first for now. Apple can follow up with XCode later. Ping reviewers Comment on attachment 338830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338830&action=review > Source/WebKit/NetworkProcess/Cookies/WebCookieManager.cpp:43 > -using namespace WebCore; > - > namespace WebKit { > +using namespace WebCore; There is a question of code style: should we leave a blank line after namespace WebKit { and before using namespace WebCore;? My inclination would have been to do so, to match the previous code style. But Keith consistently avoided the blank line when moving WebCore and the other projects to unified sources, and that is a much larger amount of code, so that's why I chose to avoid it here. There will be inconsistency either way. Comment on attachment 338830 [details]
Patch
I think this is fine. If someone is bothered by the inconsistent spacing they can establish a style guideline and fix it.
*** Bug 188719 has been marked as a duplicate of this bug. *** This will surely break Cocoa ports if committed now; it needs help from Tim or someone with XCode. The EWS are green because Cocoa ports didn't use Sources.txt at the time I uploaded the patch. Basically I think each of these unified source patches is going to require an Apple developer, since the required XCode changes are too hard to do blindly. But CMake ports should no longer require any changes after bug #188732 lands. Yeah, I’m planning on taking a stab at this shortly. Please try bug #188732 first, because that bug will get harder to handle otherwise. (In reply to Michael Catanzaro from comment #11) > Please try bug #188732 first, because that bug will get harder to handle > otherwise. Good point. OK, will go over there. Created attachment 347560 [details]
Patch
Comment on attachment 347560 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347560&action=review > Source/WebKit/ChangeLog:1 > +2018-08-20 Michael Catanzaro <mcatanzaro@igalia.com> If you like, you can add yourself here when we have shared patches: 2018-08-20 Michael Catanzaro <mcatanzaro@igalia.com> and Timothy Horton <thorton@apple.com> It doesn't show up perfectly in trac, but it works. Anyway, doesn't matter. (In reply to Michael Catanzaro from comment #14) > Comment on attachment 347560 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=347560&action=review > > > Source/WebKit/ChangeLog:1 > > +2018-08-20 Michael Catanzaro <mcatanzaro@igalia.com> > > If you like, you can add yourself here when we have shared patches: > 2018-08-20 Michael Catanzaro <mcatanzaro@igalia.com> and Timothy Horton > <thorton@apple.com> > > It doesn't show up perfectly in trac, but it works. > > Anyway, doesn't matter. You're doing the hard work, and I don't need to boost my patch count :P Comment on attachment 347560 [details] Patch Clearing flags on attachment: 347560 Committed r235101: <https://trac.webkit.org/changeset/235101> All reviewed patches have been landed. Closing bug. |