Bug 185006

Summary: WK_COCOA_TOUCH all the things.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, ews-watchlist, keith_miller, mark.lam, mitz, msaboff, saam, thorton, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=205144
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jer Noble
Reported 2018-04-25 16:08:37 PDT
WK_COCOA_TOUCH all the things.
Attachments
Patch (26.98 KB, patch)
2018-04-25 16:12 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (26.32 KB, patch)
2018-04-25 16:54 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (29.53 KB, patch)
2018-04-26 10:58 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2018-04-25 16:10:13 PDT
<rdar://problem/39736025>
Jer Noble
Comment 2 2018-04-25 16:12:23 PDT
Created attachment 338816 [details] Patch
Jer Noble
Comment 3 2018-04-25 16:54:22 PDT
Created attachment 338827 [details] Patch
Tim Horton
Comment 4 2018-04-25 17:08:20 PDT
Comment on attachment 338827 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338827&action=review > Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:41 > +FRAMEWORK_SEARCH_PATHS = $(FRAMEWORK_SEARCH_PATHS_COCOA_TOUCH_$(WK_NOT_$(WK_EMPTY_$(WK_COCOA_TOUCH)))); Plz no ____NOT_EMPTY_____
Jer Noble
Comment 5 2018-04-26 10:58:52 PDT
Created attachment 338894 [details] Patch for landing
WebKit Commit Bot
Comment 6 2018-04-26 12:15:26 PDT
Comment on attachment 338894 [details] Patch for landing Clearing flags on attachment: 338894 Committed r231063: <https://trac.webkit.org/changeset/231063>
WebKit Commit Bot
Comment 7 2018-04-26 12:15:27 PDT
All reviewed patches have been landed. Closing bug.
Jer Noble
Comment 8 2018-04-26 14:33:05 PDT
Landed iOS build fix in r231073: <https://trac.webkit.org/changeset/231073>
Note You need to log in before you can comment on or make changes to this bug.