Bug 184994

Summary: [LFC] Implement Layout::BlockContainer functions.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, sam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

zalan
Reported 2018-04-25 13:18:22 PDT
ssia
Attachments
Patch (1.90 KB, patch)
2018-04-25 13:22 PDT, zalan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2018-04-25 13:22:48 PDT
Created attachment 338778 [details] Patch
Antti Koivisto
Comment 2 2018-04-25 13:30:31 PDT
Comment on attachment 338778 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338778&action=review > Source/WebCore/layout/layouttree/LayoutBlockContainer.cpp:53 > +bool BlockContainer::establishesInlineFormattingContext() const > +{ > + // 9.4.2 Inline formatting contexts > + // An inline formatting context is established by a block container box that contains no block-level boxes. > + for (auto* child = firstInFlowChild(); child; child = child->nextInFlowSibling()) { > + if (child->isBlockLevelBox()) > + return false; > + } > + return hasInFlowOrFloatingChild(); > +} We'll probably need some sort of caching scheme for things like this. The result only changes on tree mutation after all.
zalan
Comment 3 2018-04-25 13:35:48 PDT
Committed r231017: <https://trac.webkit.org/changeset/231017>
Radar WebKit Bug Importer
Comment 4 2018-04-25 13:36:22 PDT
<rdar://problem/39732558>
Note You need to log in before you can comment on or make changes to this bug.