Bug 184966

Summary: WebDriver: several w3c collections tests added in r230953 are failing
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebDriverAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 204151    
Bug Blocks:    
Attachments:
Description Flags
Patch
bburg: review+
Patch for landing none

Carlos Garcia Campos
Reported 2018-04-25 03:19:52 PDT
imported/w3c/webdriver/tests/execute_script/collections.py::test_arguments imported/w3c/webdriver/tests/execute_script/collections.py::test_file_list imported/w3c/webdriver/tests/execute_script/collections.py::test_html_all_collection imported/w3c/webdriver/tests/execute_async_script/collections.py::test_arguments imported/w3c/webdriver/tests/execute_async_script/collections.py::test_file_list imported/w3c/webdriver/tests/execute_async_script/collections.py::test_html_all_collection
Attachments
Patch (8.11 KB, patch)
2019-12-06 06:02 PST, Carlos Garcia Campos 		bburg: review+
DetailsFormatted DiffDiff
Patch for landing (8.14 KB, patch)
2020-01-07 02:34 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2019-12-06 05:55:55 PST
This is because JSON.stringify() is not enough, we need to first clone the value using the internal JSON clone algorithm explained in the spec. See https://w3c.github.io/webdriver/#dfn-internal-json-clone-algorithm
Carlos Garcia Campos
Comment 2 2019-12-06 06:02:20 PST
Created attachment 385008 [details] Patch
Blaze Burg
Comment 3 2020-01-06 17:06:02 PST
Comment on attachment 385008 [details] Patch r=me but needs to be rebased.
Carlos Garcia Campos
Comment 4 2020-01-07 02:34:22 PST
Created attachment 386953 [details] Patch for landing
Carlos Garcia Campos
Comment 5 2020-01-07 02:45:39 PST
Committed r254120: <https://trac.webkit.org/changeset/254120>
Radar WebKit Bug Importer
Comment 6 2020-01-07 02:46:17 PST
<rdar://problem/58369241>
Note You need to log in before you can comment on or make changes to this bug.