Bug 184926 – Auto save the results for Test262

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Leo Balter]

Currently, the new Test262-runner only saves the results if called with a --save option. Test262 should generate the results file by default in full runs, while the --save option might be interesting only for creating a new expectations file, listing only failures.

[Leo Balter]

Created attachment 338668 [details]
Patch

[Leo Balter]

The latest patch also includes some minor tweaks to the t262 runner.

[Michael Saboff]

Comment on attachment 338668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338668&action=review

r=me with one suggested text change.

> Tools/Scripts/test262/Runner.pm:306
> +        print "\nSaved results in: $expectationsFile\n";

Please change this message to something like "Saved new expectations in :"

[Leo Balter]

Created attachment 338797 [details]
Patch

[Michael Saboff]

Comment on attachment 338797 [details]
Patch

r- for the moving the results and expectations to JSTestt

This should done as two patches.
 - The first patch to save the result.
 - A second patch to move things around.
I would approve the first patch.  I don't like having the test script in Tests/Scripts and the output in JSTests.  I think it does make sense to move both the runner and output files to JSTests.  That may require some rework of the current JSTests/test262 layout.

[valerie]

Created attachment 339234 [details]
Save results on every run

[Michael Saboff]

Comment on attachment 339234 [details]
Save results on every run

r=me

[WebKit Commit Bot]

Comment on attachment 339234 [details]
Save results on every run

Clearing flags on attachment: 339234

Committed r231219: <https://trac.webkit.org/changeset/231219>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39884125>