Summary: | Auto save the results for Test262 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Leo Balter <leo> | ||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, msaboff, valerie, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Leo Balter
2018-04-24 13:09:25 PDT
Created attachment 338668 [details]
Patch
The latest patch also includes some minor tweaks to the t262 runner. Comment on attachment 338668 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338668&action=review r=me with one suggested text change. > Tools/Scripts/test262/Runner.pm:306 > + print "\nSaved results in: $expectationsFile\n"; Please change this message to something like "Saved new expectations in :" Created attachment 338797 [details]
Patch
Comment on attachment 338797 [details]
Patch
r- for the moving the results and expectations to JSTestt
This should done as two patches.
- The first patch to save the result.
- A second patch to move things around.
I would approve the first patch. I don't like having the test script in Tests/Scripts and the output in JSTests. I think it does make sense to move both the runner and output files to JSTests. That may require some rework of the current JSTests/test262 layout.
Created attachment 339234 [details]
Save results on every run
Comment on attachment 339234 [details]
Save results on every run
r=me
Comment on attachment 339234 [details] Save results on every run Clearing flags on attachment: 339234 Committed r231219: <https://trac.webkit.org/changeset/231219> All reviewed patches have been landed. Closing bug. |