Bug 184913

Summary: [GTK] Implement MouseEvent.buttons
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, Ms2ger, zan
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 174616    
Attachments:
Description Flags
Patch zan: review+

Carlos Garcia Campos
Reported 2018-04-24 06:27:49 PDT
It's currently returning always 0 for WebKitGTK+. https://www.w3.org/TR/uievents/#ref-for-dom-mouseevent-buttons-1
Attachments
Patch (14.68 KB, patch)
2018-04-24 06:34 PDT, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2018-04-24 06:34:39 PDT
Created attachment 338644 [details] Patch
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 2 2018-04-25 01:09:31 PDT
Comment on attachment 338644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338644&action=review > Source/WebKit/Shared/gtk/WebEventFactory.cpp:154 > + unsigned modifier = 1 << (8 + event->button.button - 1); I've seen this calculation about five times in this patch; worth writing a small helper function?
Carlos Garcia Campos
Comment 3 2018-04-25 03:17:11 PDT
Committed r230988: <https://trac.webkit.org/changeset/230988>
Note You need to log in before you can comment on or make changes to this bug.