Bug 184862

Summary: [Modern Media Controls] Obtain compact mode icons through WebKitAdditions
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=186034
Attachments:
Description Flags
Patch jonlee: review+

Antoine Quint
Reported 2018-04-21 11:30:19 PDT
For the media controls compact mode some extra icons are provided through WebKitAdditions. We need to update the media controls code to copy them to the WebCore bundle and to know how to load them.
Attachments
Patch (6.01 KB, patch)
2018-04-21 11:34 PDT, Antoine Quint 		jonlee: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2018-04-21 11:30:32 PDT
<rdar://problem/39621645>
Antoine Quint
Comment 2 2018-04-21 11:34:05 PDT
Created attachment 338527 [details] Patch
EWS Watchlist
Comment 3 2018-04-21 11:36:11 PDT
Attachment 338527 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:9: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dean Jackson
Comment 4 2018-04-21 12:21:51 PDT
Comment on attachment 338527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338527&action=review > Source/WebCore/ChangeLog:9 > + No new tests (OOPS!). Remember to remove this.
Antoine Quint
Comment 5 2018-04-21 14:48:02 PDT
Committed r230894: <https://trac.webkit.org/changeset/230894>
Note You need to log in before you can comment on or make changes to this bug.